This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 407
WIP(async): support native async/await #1140
Open
JiaLiPassion
wants to merge
4
commits into
angular:master
Choose a base branch
from
JiaLiPassion:async
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiaLiPassion
changed the title
feat(async): support native async/await
WIP(async): support native async/await
Sep 24, 2018
Hi @JiaLiPassion, do you have any update on this? |
Hi @JiaLiPassion have you time to correct integrations fails? |
@KrzysztofKarol , @jguyenot , there are some cases this solution will not work, I will continue to find another solution, thanks! |
Thanks for your time. It's actually impossible to implement lazy loading module with angular 8 and zone.js so it's very important. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #740, #795.
I think I may find a way to resolve
native async/await
issue.The test code below works well.
@mhevery, I will continue to add test cases, hope it can work.