Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Commit 2594940

Browse files
bsergeimhevery
authored andcommitted
fix(timers): cleanup task reference when exception (#637)
1 parent e783bfa commit 2594940

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

lib/common/timers.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,11 @@ export function patchTimer(window: any, setName: string, cancelName: string, nam
2424
function scheduleTask(task: Task) {
2525
const data = <TimerOptions>task.data;
2626
data.args[0] = function() {
27-
task.invoke.apply(this, arguments);
28-
delete tasksByHandleId[data.handleId];
27+
try {
28+
task.invoke.apply(this, arguments);
29+
} finally {
30+
delete tasksByHandleId[data.handleId];
31+
}
2932
};
3033
data.handleId = setNative.apply(window, data.args);
3134
tasksByHandleId[data.handleId] = task;

0 commit comments

Comments
 (0)