Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

feat(autocomplete): option to toggle the clear button #9892

Merged
merged 1 commit into from
Oct 27, 2016
Merged

feat(autocomplete): option to toggle the clear button #9892

merged 1 commit into from
Oct 27, 2016

Conversation

devversion
Copy link
Member

@devversion devversion commented Oct 22, 2016 •
edited
Loading

  • Adds a new attribute, which allows developers to explicitly show the clear button for all types of autocomplete's.

Closes #4841. Closes #2727

@devversion devversion added the needs: review This PR is waiting on review from the team label Oct 22, 2016
@ThomasBurleson
Copy link
Contributor

@devversion - Questions:

  1. Is this consistent with the hide clear button api ?
  2. Does this work with the hide features; if so which one supercedes ?

topherfangio
topherfangio previously requested changes Oct 24, 2016
View reviewed changes
Copy link
Contributor

@topherfangio topherfangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite sure what logic is wrong, but in testing this manually; I still see the button even with md-clear-button="false" when added to the basic usage demo.

@devversion
Copy link
Member Author

@topherfangio Not sure about this. I just tried it out again and it works for me - Let's pair on chat about it.

@topherfangio topherfangio dismissed their stale review October 24, 2016 18:32

Error with my localhost server.

topherfangio
topherfangio approved these changes Oct 24, 2016
View reviewed changes
Copy link
Contributor

@topherfangio topherfangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@topherfangio topherfangio mentioned this pull request Oct 24, 2016
Closed
@topherfangio
Copy link
Contributor

Note that this will also close #4841

@devversion Can you please add that to the commit description so it gets closed when this is merged?

@topherfangio topherfangio added needs: presubmit and removed needs: review This PR is waiting on review from the team labels Oct 24, 2016
@devversion
feat(autocomplete): option to toggle the clear button
6dd9950 
*  Adds a new attribute, which allows developers to explicitly show the clear button for all types of autocomplete's.

Closes angular#4841. Closes angular#2727
@devversion devversion force-pushed the feat/autocomplete-clear-button branch from 5fe4f27 to 6dd9950 Compare October 24, 2016 18:37
@devversion
Copy link
Member Author

@topherfangio Done! Thanks for looking into it.

@ThomasBurleson ThomasBurleson added this to the 1.1.2 milestone Oct 24, 2016
@jelbourn jelbourn merged commit 70cecda into angular:master Oct 27, 2016
@devversion devversion deleted the feat/autocomplete-clear-button branch October 27, 2016 19:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@topherfangio topherfangio topherfangio approved these changes

Assignees

@ThomasBurleson ThomasBurleson

Labels
None yet
Projects
None yet
Milestone
1.1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @ThomasBurleson @topherfangio @jelbourn