This repository was archived by the owner on Dec 18, 2024. It is now read-only.
build: fix site not loading due to dataSource exception #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splaktar
force-pushed
the
fixDataSourceException
branch
from
103e67f to
f0b546a
Compare
Splaktar
force-pushed
the
fixDataSourceException
branch
from
f0b546a to
f61be14
Compare
|
@andrewseguin take a look? |
|
Ah, I just looked. Should be captured in other PRs that were merged. |
|
Yep, looks like #434 included these changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #426
Fixing this leads to the app loading (instead of white screen), but then exceptions are thrown due to missing
BottomSheetModule. Those are fixed in angular/components#10947.