fix(autocomplete): escape key inconsistency on IE #9777
Merged
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brings the autocomplete escape key behavior on IE in line with other browsers. Currently pressing escape on IE will cause it to revert the display value to the one it had on focus, however it won't dispatch any events and the model value will be out of sync. None of the other browsers (event Edge) have this behavior.
googlebot
added
the
cla: yes
jelbourn
reviewed
Feb 5, 2018
| // in line with other browsers. By default, pressing escape on IE will cause it to revert | ||
| // the input value to the one that it had on focus, however it won't dispatch any events | ||
| // which means that the model value will be out of sync with the view. | ||
| if (keyCode === ESCAPE) { |
There was a problem hiding this comment.
Would it make sense to specifically target IE with this?
There was a problem hiding this comment.
I suppose, but other browsers don't do anything with it anyway so it wasn't worth changing the constructor signature.
jelbourn
added
pr: lgtm
action: merge
mmalerba
pushed a commit
that referenced
this pull request
Feb 8, 2018
Brings the autocomplete escape key behavior on IE in line with other browsers. Currently pressing escape on IE will cause it to revert the display value to the one it had on focus, however it won't dispatch any events and the model value will be out of sync. None of the other browsers (event Edge) have this behavior.
tinayuangao
pushed a commit
that referenced
this pull request
Feb 9, 2018
Brings the autocomplete escape key behavior on IE in line with other browsers. Currently pressing escape on IE will cause it to revert the display value to the one it had on focus, however it won't dispatch any events and the model value will be out of sync. None of the other browsers (event Edge) have this behavior.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings the autocomplete escape key behavior on IE in line with other browsers. Currently pressing escape on IE will cause it to revert the display value to the one it had on focus, however it won't dispatch any events and the model value will be out of sync. None of the other browsers (event Edge) have this behavior.