-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(stepper): add the ability to reset a stepper #8623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
this.completed = false; | ||
|
||
if (this.stepControl) { | ||
this.stepControl.reset(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I'm open to having this reset only the dirty
and touched
states. I went with reset
, because leaving behind the value didn't seem like a "true" reset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like the most common use case to me. If we get lot of requests for reset all but the value we could create a new method: {reset,clear}{Status,State}
this.completed = false; | ||
|
||
if (this.stepControl) { | ||
this.stepControl.reset(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like the most common use case to me. If we get lot of requests for reset all but the value we could create a new method: {reset,clear}{Status,State}
@crisbeto I set the milestone to 5.2 since this seems less severe than some of the other things we want to get in for 5.1. I'd be fine moving it to 5.1 if we have time after merging the other fixes |
I'm fine with leaving it for 5.2. |
d5bbfed
to
dfc5edd
Compare
See CI errors
|
dfc5edd
to
71559c8
Compare
Sorted out the error in the example. |
Allows for the user to reset a stepper to its initial state by calling the `reset` method. Relates to angular#7700.
71559c8
to
a0062f4
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Allows for the user to reset a stepper to its initial state by calling the
reset
method.Relates to #7700.