universal: dump out the prerendered file so we can examine it #8483
Conversation
googlebot
added
the
cla: yes
| @@ -15,7 +15,10 @@ const result = renderModuleFactory(KitchenSinkServerModuleNgFactory, { | |||
| }); | |||
|
|
|||
| result | |||
| .then(() => log('Prerender done.')) | |||
| .then(content => { | |||
| writeFileSync(join(__dirname, 'index-prerendered.html'), content, 'utf-8'); | |||
There was a problem hiding this comment.
Shouldn't we output that file in the dist/ folder?
There was a problem hiding this comment.
Yeah, should be under dist/. I thought I added this when I originally wrote this...
There was a problem hiding this comment.
Initially it just printed out the file in the console, but that made it hard to see any exceptions.
There was a problem hiding this comment.
Yeah that's too much. We should just write it to dist/index-prerendered.html and also not under dist/packages/demo-app since it's actually the universal app.
Idea: If we fully use CircleCI at some point, there is the option to upload the index file as an artifact. Meaning that we can download and inspect the output file easily.
There was a problem hiding this comment.
Why not under dist/packages/universal-app? That's actually what I meant to do, just copy/paste-failed
There was a problem hiding this comment.
Apparently I can't import {buildConfig} from 'material2-build-tools' in this file and __dirname seems to point to the correct directory anyways, since we're running the version of the prerender script from dist/packages/universal-app, so... just gonna switch this back to how it was originally
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.