build: dedupe theming scss bundle #4174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Apr 20, 2017
tools/gulp/tasks/release.ts
Outdated
| @@ -32,6 +27,10 @@ const themingEntryPointPath = join(COMPONENTS_DIR, 'core', 'theming', '_all-them | |||
| // Output path for the scss theming bundle. | |||
| const themingBundlePath = join(releasePath, '_theming.scss'); | |||
|
|
|||
| // Glob that matches all files that might be imported multiple times. | |||
| // Necessary for deduping inside of scss-bundle. | |||
| const themingBundleDedupeGlob = join(COMPONENTS_DIR, '**/*.scss'); | |||
There was a problem hiding this comment.
Should be named for what is it rather than how it's used, e.g., allScssGlob
There was a problem hiding this comment.
I named it themingBundleDedupeGlob because I wanted to make it clear that this will be the array that holds the files that might need deduping. Changed it because the comment below explains it then.
tools/gulp/tasks/release.ts
Outdated
| ], {silentStdout: true} | ||
| )); | ||
| task(':bundle:theming-scss', () => { | ||
| new Bundler().Bundle(themingEntryPointPath, [themingBundleDedupeGlob]).then(result => { |
There was a problem hiding this comment.
Could you comment on what the arguments are here since it's not really clear from the call site?
* Updates to a more recent version of SCSS-bundle that has support for deduping. The dedupe process is very naive and only disallows importing a file multiple times. * Switches to the programmatic API of `scss-bundle` * Removes unused functions and imports / leftovers. Fixes angular#3931
devversion
force-pushed
the
build/dedupe-theming-scss
branch
from
1fc9a3a
to
d364b6e
Compare
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scss-bundleFixes #3931