Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(theming): log a warning if core theme isn't loaded #3781

Merged
merged 2 commits into from
Mar 29, 2017
Merged

feat(theming): log a warning if core theme isn't loaded #3781

merged 2 commits into from
Mar 29, 2017

Commits on Mar 25, 2017

  1. feat(theming): log a warning if core theme isn't loaded 

    * Checks the user's loaded stylesheets and logs a warning if the Material core theme isn't loaded.
* Fixes a wrong `typeof` check when determining the doctype.

Fixes angular#2828.

Note: I originally went with looping through the `document.styleSheets` to check whether the selector is defined, however I had to switch back to `getComputedStyle`, because browsers don't expose the `document.styleSheets`, if the CSS file is being loaded from another domain. This would've caused the warning to be logged if the user loads over a CDN.
    @crisbeto
    crisbeto committed Mar 25, 2017
    Configuration menu
    Copy the full SHA
    068f416 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2017

  1. refactor: address feedback

    @crisbeto
    crisbeto committed Mar 28, 2017
    Configuration menu
    Copy the full SHA
    0dd4416 View commit details
    Browse the repository at this point in the history