Skip to content

fix(button-toggle): Use a lighter color for focused layer in button-toggle #3232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 23, 2017
Merged

fix(button-toggle): Use a lighter color for focused layer in button-toggle #3232

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c10c4fb
Use a lighter color for focused layer in button-toggle
tinayuangao Feb 21, 2017
f70bb52
.
tinayuangao Feb 21, 2017
1f5dfb1
Only show focus layer when keyboard focus
tinayuangao Feb 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/lib/core/theming/_palette.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ $black-87-opacity: rgba(black, 0.87);
$white-87-opacity: rgba(white, 0.87);
$black-12-opacity: rgba(black, 0.12);
$white-12-opacity: rgba(white, 0.12);
$black-6-opacity: rgba(black, 0.06);
$white-6-opacity: rgba(white, 0.06);

$mat-red: (
50: #ffebee,
Expand Down Expand Up @@ -653,7 +655,7 @@ $mat-light-theme-background: (
dialog: white,
disabled-button: $black-12-opacity,
raised-button: white,
dark-overlay: $black-12-opacity,
dark-overlay: $black-6-opacity,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make the name for this focused-button to match disabled-button and raised-button above? dark-overlay is kind of a misnomer in the dark theme anyways

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks for review!

);

// Background palette for dark themes.
Expand All @@ -666,7 +668,7 @@ $mat-dark-theme-background: (
dialog: map_get($mat-grey, 800),
disabled-button: $white-12-opacity,
raised-button: map-get($mat-grey, 800),
dark-overlay: $white-12-opacity,
dark-overlay: $white-6-opacity,
);

// Foreground palette for light themes.
Expand Down