Skip to content

fix(material/button-toggle): simplify divider color #31214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 24, 2025

Conversation

andrewseguin
Copy link
Contributor

Change already landed internally with divider changes - was missed on the divider PR #31200

@andrewseguin andrewseguin requested a review from a team as a code owner May 24, 2025 11:53
@andrewseguin andrewseguin requested review from adolgachev and ok7sai and removed request for a team May 24, 2025 11:53
@andrewseguin andrewseguin added the target: minor This PR is targeted for the next minor release label May 24, 2025
@andrewseguin andrewseguin requested a review from crisbeto May 24, 2025 11:53
@crisbeto
Copy link
Member

I think that this one will be a bit of regression. Note how the left border on the selected toggle is different from the border around the group:
image

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the assumption that we'll follow this up with another fix for the border.

@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label May 24, 2025
@andrewseguin andrewseguin merged commit a7150d4 into angular:main May 24, 2025
16 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: material/button-toggle target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants