Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: increase minimum angular version #3017

Merged
merged 1 commit into from
Feb 10, 2017

Conversation

devversion
Copy link
Member

@devversion devversion commented Feb 9, 2017

  • Currently Angular Material supports Angular v2.2.0, but some components already use methods that are only available in v2.3.0.
    This means that Material isn't really compatible with v2.2.0 anymore.

  • Since Angular v.2.3.0 includes a lot of good fixes (like proper metadata inheritance) we should upgrade to v2.3.0.
    See for example angular/angular@f5c8e09

Note: This also fixes the invalid peerDependencies warning for Material.

Related to #2394

@devversion devversion requested a review from kara February 9, 2017 18:54
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 9, 2017
* Currently Angular Material supports Angular v2.2.0, but some components already use methods that are only available in `v2.3.0`.
  This means that Material isn't really compatible with v2.2.0 anymore.

* Since Angular `v.2.3.0` includes a lot of good fixes (like proper metadata inheritance) we should upgrade to `v2.3.0`.
  See angular/angular@f5c8e09

Related to angular#2394
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Feb 10, 2017
@kara kara removed their assignment Feb 10, 2017
@tinayuangao tinayuangao merged commit 140c95c into angular:master Feb 10, 2017
@devversion devversion deleted the build/update-angular branch March 17, 2017 19:31
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants