Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(slider): show background-color in print stylesheet (#11364) #22300

Merged
merged 1 commit into from
Mar 23, 2021
Merged

feat(slider): show background-color in print stylesheet (#11364) #22300

merged 1 commit into from
Mar 23, 2021

Conversation

felhag
Copy link
Contributor

@felhag felhag commented Mar 20, 2021

  • added color-adjust to mat-slider-wrapper to display slider correctly while printing

@felhag felhag requested a review from mmalerba as a code owner March 20, 2021 09:49
@google-cla
Copy link

google-cla bot commented Mar 20, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Mar 20, 2021
@google-cla
Copy link

google-cla bot commented Mar 20, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Mar 20, 2021
crisbeto
crisbeto reviewed Mar 21, 2021
View reviewed changes
src/material/slider/_slider-theme.scss Outdated
@@ -49,6 +49,11 @@
theming.get-color-from-palette($foreground, base, $mat-slider-tick-opacity);
$mat-slider-tick-size: 2px;

.mat-slider-wrapper {
-webkit-print-color-adjust: exact;
color-adjust: exact;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you leave a comment saying why this is necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It forces the browser to include the background color when the print function is used. I didn't include a media query for printing because the spec is not specifically intended for printing and a slider without the background-color doesn't make any sense.

Before:
image

After:
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm aware what it does, but we should have a comment in the code so it doesn't get deleted. Also I think that this should be in _slider.scss, not _slider-theme.scss.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! I updated the pull request.

@felhag
feat(material/slider): show background-color in print stylesheet (ang…
25778cf 
…ular#11364)

* added color-adjust to mat-slider-wrapper to display slider correctly while printing
crisbeto
crisbeto approved these changes Mar 21, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 21, 2021
@andrewseguin andrewseguin merged commit 69a8fb5 into angular:master Mar 23, 2021
andrewseguin pushed a commit that referenced this pull request Mar 23, 2021
@felhag @andrewseguin
feat(material/slider): show background-color in print stylesheet (#11364
059214e 
) (#22300)

* added color-adjust to mat-slider-wrapper to display slider correctly while printing

(cherry picked from commit 69a8fb5)
@felhag felhag mentioned this pull request Mar 23, 2021
Merged
@felhag felhag mentioned this pull request Mar 30, 2021
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felhag @crisbeto @andrewseguin