Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(radio/checkbox): show background-color in print stylesheet (#22298) #22299

Merged
merged 3 commits into from
Mar 30, 2021
Merged

feat(radio/checkbox): show background-color in print stylesheet (#22298) #22299

merged 3 commits into from
Mar 30, 2021

Conversation

felhag
Copy link
Contributor

@felhag felhag commented Mar 20, 2021

  • added color-adjust for radio background-color
  • added color-adjust for checkbox background-color

@google-cla
Copy link

google-cla bot commented Mar 20, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Mar 20, 2021
@google-cla
Copy link

google-cla bot commented Mar 20, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Mar 20, 2021
@felhag
Copy link
Contributor Author

felhag commented Mar 23, 2021

Updated pull request by implementing feedback from @crisbeto in #22300 on this branch as well.

crisbeto
crisbeto reviewed Mar 25, 2021
View reviewed changes
src/material/checkbox/checkbox.scss
// force browser to show background-color when using the print function
-webkit-print-color-adjust: exact;
color-adjust: exact;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we'll need the same fixes for the mdc-radio and mdc-checkbox.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I open a new pr/issue in the MDC repository or update the material/experimental mdc components in this pull request?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine to fix it on our end for now. If MDC ends up resolving it on their end, we can remove our workaround.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an additional commit for the mdc-checkbox. The mdc-radio was printed fine because it uses a border for the inner circle.

@felhag
feat(material-experimental/mdc-checkbox): show background-color in pr…
f0c910c 
…int stylesheet (angular#22298)

* added color-adjust for checkbox background-color
@felhag felhag requested a review from mmalerba as a code owner March 25, 2021 20:55
crisbeto
crisbeto approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 26, 2021
@wagnermaciel wagnermaciel merged commit 5fd431f into angular:master Mar 30, 2021
wagnermaciel pushed a commit that referenced this pull request Mar 30, 2021
@felhag @wagnermaciel
feat(radio/checkbox): show background-color in print stylesheet (#22298…
0687780 
…) (#22299)

* feat(material/radio): show background-color in print stylesheet (#22298)

* added color-adjust for radio background-color

* feat(material/checkbox): show background-color in print stylesheet (#22298)

* added color-adjust for checkbox background-color

* feat(material-experimental/mdc-checkbox): show background-color in print stylesheet (#22298)

* added color-adjust for checkbox background-color

(cherry picked from commit 5fd431f)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion Awaiting requested review from devversion

@jelbourn jelbourn Awaiting requested review from jelbourn

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felhag @crisbeto @wagnermaciel