perf(form-field): convert adapter to a class object #19982
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
approved these changes
Jul 15, 2020
There was a problem hiding this comment.
LGTM. Same as in #19985, it would be nice to see how this improves performance. Regardless of performance though, I think this would be a nice change (for improved readability).
This fix converts the private adapter into a class object to hopefully improve memory usage
ngwattcos
force-pushed
the
optimize-form-field
branch
from
0c1b99c to
22f7394
Compare
…outside of constructor
mmalerba
reviewed
Jul 20, 2020
kseamon
reviewed
Jul 21, 2020
mmalerba
added
G
jelbourn
added
target: patch
andrewseguin
removed
the
cla: yes
|
We will soon be taking out our dependency on the adapters provided by MDC since they won't be supported later. Thank you for your contribution, sorry we weren't able to land this |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix converts the private adapter into a class object to hopefully improve memory usage
Edit: performance improvements should be comparable to #19980