build: don't flag noop mixins in theme mixin rule #19558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `theme-mixin-api` rule flags any mixin that doesn't include a variable that extracts the config. This can be annoying for noop placeholder mixins since we have to declare a variable that won't be used. These changes add an exception for mixins that are empty or only contain comment nodes.
crisbeto
added
P3
crisbeto
requested review from
andrewseguin,
devversion,
jelbourn,
mmalerba and
a team
as code owners
googlebot
added
the
cla: yes
|
Bumping this up from patch since it doesn't cleaning go into |
andrewseguin
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
theme-mixin-apirule flags any mixin that doesn't include a variable that extracts the config. This can be annoying for noop placeholder mixins since we have to declare a variable that won't be used. These changes add an exception for mixins that are empty or only contain comment nodes.