fix(checkbox): pass aria-describedby through to input - #19495
Merged
Conversation
Passes the `aria-describedby` attribute value through to the underlying `input` element. Fixes angular#19477.
crisbeto
added
P3
googlebot
added
the
cla: yes
jelbourn
approved these changes
Jun 5, 2020
jelbourn
left a comment
jelbourn
left a comment
Contributor
There was a problem hiding this comment.
LGTM
I'm starting to regret not making the native input part of the API...
jelbourn
pushed a commit
that referenced
this pull request
Jun 5, 2020
Passes the `aria-describedby` attribute value through to the underlying `input` element. Fixes #19477.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passes the
aria-describedbyattribute value through to the underlyinginputelement.Fixes #19477.