fix(material-experimental/mdc-slider): remove slider theme from all-theme #19411
Conversation
…heme The MDC Web slider is going to be basically get rewritten. Removing the current CSS from the all-theme until we can update this to the new version.
googlebot
added
the
cla: yes
| @@ -6,7 +6,6 @@ | |||
| @import '../mdc-menu/menu-theme'; | |||
| @import '../mdc-radio/radio-theme'; | |||
| @import '../mdc-slide-toggle/slide-toggle-theme'; | |||
| @import '../mdc-slider/slider-theme'; | |||
There was a problem hiding this comment.
Wouldn't this prevent us from catching any bugs in the dev app until MDC are done updating their slider? It might be better to leave it as it is and then swap it out when MDC have released the rewrite.
There was a problem hiding this comment.
LGTM. Though would also agree with Kristiyan's point here. Is the theme used internally in g3 and conflicts? I haven't look at their repo, but they mentioned the rework when we already started with that one (08/2019), and we're still here with no new API we'd need to update to.
|
You got it- this was causing a problem in Google because the import path changed. I also want to exclude the mdc-slider styles from all-theme because we 100% know people won't be using them in the current form, so they're inherently unused styles. |
jelbourn
added
action: merge
|
Merging as merge-safe because I already made this change in Google. |
jelbourn
added
target: major
In angular#19411 the MDC slider theme was dropped from the all themes mixin since the current slider implementation will be replaced eventually which also broke the MDC slider demo. These changes add back the slider theme only to the dev app so that we can still test it since this is still code that we're releasing to npm.
In angular#19411 the MDC slider theme was dropped from the all themes mixin since the current slider implementation will be replaced eventually which also broke the MDC slider demo. These changes add back the slider theme only to the dev app so that we can still test it since this is still code that we're releasing to npm.
In #19411 the MDC slider theme was dropped from the all themes mixin since the current slider implementation will be replaced eventually which also broke the MDC slider demo. These changes add back the slider theme only to the dev app so that we can still test it since this is still code that we're releasing to npm.
In #19411 the MDC slider theme was dropped from the all themes mixin since the current slider implementation will be replaced eventually which also broke the MDC slider demo. These changes add back the slider theme only to the dev app so that we can still test it since this is still code that we're releasing to npm.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The MDC Web slider is going to be basically get rewritten. Removing the current CSS from the all-theme until we can update this to the new version.