fix(youtube-player): unable to bind to events after initialization#18996
Merged
Conversation
The `youtube-player` component is set up so that it won't bind any events if there aren't any listeners at the time the player is created. This makes it impossible to bind an event by getting a reference to the player using `ViewChild` and subscribing to it. These changes fix the issue using a lazy observable which binds any events once the user subscribes and transfers them between players.
crisbeto
added
P3
googlebot
added
the
cla: yes
crisbeto
commented
Apr 5, 2020
| @@ -1,15 +1,15 @@ | |||
| export declare class YouTubePlayer implements AfterViewInit, OnDestroy, OnInit { | |||
| apiChange: EventEmitter<YT.PlayerEvent>; | |||
| apiChange: Observable<YT.PlayerEvent>; | |||
Member
Author
There was a problem hiding this comment.
This is technically a public API change, but Observable and EventEmitter have the same signature, aside from emit which people shouldn't be accessing on our outputs anyway.
jelbourn
pushed a commit
that referenced
this pull request
Apr 24, 2020
…18996) The `youtube-player` component is set up so that it won't bind any events if there aren't any listeners at the time the player is created. This makes it impossible to bind an event by getting a reference to the player using `ViewChild` and subscribing to it. These changes fix the issue using a lazy observable which binds any events once the user subscribes and transfers them between players.
soro-google
pushed a commit
to soro-google/components
that referenced
this pull request
Apr 24, 2020
…ngular#18996) The `youtube-player` component is set up so that it won't bind any events if there aren't any listeners at the time the player is created. This makes it impossible to bind an event by getting a reference to the player using `ViewChild` and subscribing to it. These changes fix the issue using a lazy observable which binds any events once the user subscribes and transfers them between players.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
youtube-playercomponent is set up so that it won't bind any events if there aren't any listeners at the time the player is created. This makes it impossible to bind an event by getting a reference to the player usingViewChildand subscribing to it. These changes fix the issue using a lazy observable which binds any events once the user subscribes and transfers them between players.