feat(datepicker): allow for the dropdown position to be customized - #16698
Merged
jelbourn merged 1 commit intoApr 24, 2020
Conversation
crisbeto
added
P3
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
16550/datepicker-popup-position
branch
2 times, most recently
from
August 6, 2019 14:05
605993f to
659fb5a
Compare
mmalerba
reviewed
Aug 6, 2019
SERGEES
reviewed
Aug 28, 2019
| const primaryY = this.yPosition === 'above' ? 'bottom' : 'top'; | ||
| const secondaryY = primaryY === 'top' ? 'bottom' : 'top'; | ||
|
|
||
| return strategy.withPositions([ |
There was a problem hiding this comment.
@crisbeto maybe you could allow to pass ConnectedPosition so any consumer had full controll if needed.
As sometimes its realy needed to add offsets or class to overlay
And lines 509-512 would go away
Member
Author
There was a problem hiding this comment.
Doing that feels like we'd give people the ability to shoot themselves in the foot since they could pass in a configuration that makes the datepicker harder to use.
crisbeto
force-pushed
the
16550/datepicker-popup-position
branch
from
September 11, 2019 20:15
659fb5a to
e8c8187
Compare
crisbeto
force-pushed
the
16550/datepicker-popup-position
branch
2 times, most recently
from
November 17, 2019 17:29
77a3387 to
74a66bd
Compare
crisbeto
force-pushed
the
16550/datepicker-popup-position
branch
from
January 4, 2020 15:25
74a66bd to
64992fd
Compare
crisbeto
force-pushed
the
16550/datepicker-popup-position
branch
from
January 26, 2020 15:40
64992fd to
ccffcbb
Compare
Member
Author
|
@mmalerba I totally forgot about this PR. I've addressed your feedback from a few months ago. Can you take another look? |
mmalerba
approved these changes
Jan 27, 2020
mmalerba
added
pr: lgtm
action: merge
Allows the consumer to customize the primary position of the datepicker in dropdown mode. Fixes angular#16550.
crisbeto
force-pushed
the
16550/datepicker-popup-position
branch
from
March 30, 2020 19:51
ccffcbb to
7ae7919
Compare
soro-google
pushed a commit
to soro-google/components
that referenced
this pull request
Apr 24, 2020
…ngular#16698) Allows the consumer to customize the primary position of the datepicker in dropdown mode. Fixes angular#16550.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the consumer to customize the primary position of the datepicker in dropdown mode.
Fixes #16550.