feat(datepicker): allow for the dropdown position to be customized #16698
Conversation
crisbeto
added
P3
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
16550/datepicker-popup-position
branch
2 times, most recently
from
605993f
to
659fb5a
Compare
| const primaryY = this.yPosition === 'above' ? 'bottom' : 'top'; | ||
| const secondaryY = primaryY === 'top' ? 'bottom' : 'top'; | ||
|
|
||
| return strategy.withPositions([ |
There was a problem hiding this comment.
@crisbeto maybe you could allow to pass ConnectedPosition so any consumer had full controll if needed.
As sometimes its realy needed to add offsets or class to overlay
And lines 509-512 would go away
There was a problem hiding this comment.
Doing that feels like we'd give people the ability to shoot themselves in the foot since they could pass in a configuration that makes the datepicker harder to use.
crisbeto
force-pushed
the
16550/datepicker-popup-position
branch
from
659fb5a
to
e8c8187
Compare
crisbeto
force-pushed
the
16550/datepicker-popup-position
branch
2 times, most recently
from
77a3387
to
74a66bd
Compare
crisbeto
force-pushed
the
16550/datepicker-popup-position
branch
from
74a66bd
to
64992fd
Compare
crisbeto
force-pushed
the
16550/datepicker-popup-position
branch
from
64992fd
to
ccffcbb
Compare
|
@mmalerba I totally forgot about this PR. I've addressed your feedback from a few months ago. Can you take another look? |
mmalerba
added
pr: lgtm
action: merge
Allows the consumer to customize the primary position of the datepicker in dropdown mode. Fixes angular#16550.
crisbeto
force-pushed
the
16550/datepicker-popup-position
branch
from
ccffcbb
to
7ae7919
Compare
…ngular#16698) Allows the consumer to customize the primary position of the datepicker in dropdown mode. Fixes angular#16550.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Allows the consumer to customize the primary position of the datepicker in dropdown mode.
Fixes #16550.