Skip to content

docs(radio): add aria labelling to examples #15150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2019

Conversation

crisbeto
Copy link
Member

Adds the missing labels to a couple of the radio button live examples.

Fixes #15026.

Adds the missing labels to a couple of the radio button live examples.

Fixes angular#15026.
@crisbeto crisbeto added pr: merge safe target: patch This PR is targeted for the next patch release labels Feb 11, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner February 11, 2019 19:13
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 11, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 11, 2019
@jelbourn jelbourn merged commit d0659eb into angular:master Feb 11, 2019
jelbourn pushed a commit that referenced this pull request Feb 11, 2019
Adds the missing labels to a couple of the radio button live examples.

Fixes #15026.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Radio button example is missing a group label
3 participants