chore(demo): add examples to demo app #10743
Conversation
googlebot
added
the
cla: yes
andrewseguin
added
pr: needs review
target: patch
andrewseguin
force-pushed
the
demo-examples
branch
from
937b256 to
05ce1d2
Compare
andrewseguin
force-pushed
the
demo-examples
branch
from
05ce1d2 to
c569195
Compare
|
I'm concerned this will make the demo-app super slow. Does it make the demo app super slow? |
|
Based on a rough experiment, I found that it took the following number of seconds to refresh the demo app and open the main sidenav: On master: 16.0s, 15.9s, 16.0s So maybe half a second longer. Then again I might have grown a tired finger pushing the start button my stopwatch =) Overall, no real perceptible difference. |
| @@ -56,7 +59,7 @@ import {SnackBarDemo} from '../snack-bar/snack-bar-demo'; | |||
| import {StepperDemo} from '../stepper/stepper-demo'; | |||
| import {TableDemoModule} from '../table/table-demo-module'; | |||
| import { | |||
| Counter, FoggyTabContent, RainyTabContent, SunnyTabContent, TabsDemo | |||
| Counter,FoggyTabContent, RainyTabContent, SunnyTabContent, TabsDemo | |||
jelbourn
added
pr: lgtm
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
This reverts commit 68b1f2a.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Includes changes in PR #10739
Adds all examples to an example page on the demo app.