Skip to content

Commit b607297

Browse files
committed
rename input-container to form-field
1 parent 863bd28 commit b607297

File tree

9 files changed

+143
-148
lines changed

9 files changed

+143
-148
lines changed

src/demo-app/datepicker/datepicker-demo.html

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -9,20 +9,20 @@ <h2>Options</h2>
99
<md-input-container>
1010
<input mdInput [mdDatepicker]="minDatePicker" [(ngModel)]="minDate" placeholder="Min date">
1111
<md-datepicker-toggle mdSuffix [for]="minDatePicker"></md-datepicker-toggle>
12+
<md-datepicker #minDatePicker [touchUi]="touch" [disabled]="datepickerDisabled"></md-datepicker>
1213
</md-input-container>
13-
<md-datepicker #minDatePicker [touchUi]="touch" [disabled]="datepickerDisabled"></md-datepicker>
1414
<md-input-container>
1515
<input mdInput [mdDatepicker]="maxDatePicker" [(ngModel)]="maxDate" placeholder="Max date">
1616
<md-datepicker-toggle mdSuffix [for]="maxDatePicker"></md-datepicker-toggle>
17+
<md-datepicker #maxDatePicker [touchUi]="touch" [disabled]="datepickerDisabled"></md-datepicker>
1718
</md-input-container>
18-
<md-datepicker #maxDatePicker [touchUi]="touch" [disabled]="datepickerDisabled"></md-datepicker>
1919
</p>
2020
<p>
2121
<md-input-container>
2222
<input mdInput [mdDatepicker]="startAtPicker" [(ngModel)]="startAt" placeholder="Start at date">
2323
<md-datepicker-toggle mdSuffix [for]="startAtPicker"></md-datepicker-toggle>
24+
<md-datepicker #startAtPicker [touchUi]="touch" [disabled]="datepickerDisabled"></md-datepicker>
2425
</md-input-container>
25-
<md-datepicker #startAtPicker [touchUi]="touch" [disabled]="datepickerDisabled"></md-datepicker>
2626
</p>
2727

2828
<h2>Result</h2>
@@ -40,20 +40,20 @@ <h2>Result</h2>
4040
placeholder="Pick a date"
4141
(dateInput)="onDateInput($event)"
4242
(dateChange)="onDateChange($event)">
43+
<md-datepicker
44+
#resultPicker
45+
[touchUi]="touch"
46+
[disabled]="datepickerDisabled"
47+
[startAt]="startAt"
48+
[startView]="yearView ? 'year' : 'month'">
49+
</md-datepicker>
4350
<md-error *ngIf="resultPickerModel.hasError('mdDatepickerParse')">
4451
"{{resultPickerModel.getError('mdDatepickerParse').text}}" is not a valid date!
4552
</md-error>
4653
<md-error *ngIf="resultPickerModel.hasError('mdDatepickerMin')">Too early!</md-error>
4754
<md-error *ngIf="resultPickerModel.hasError('mdDatepickerMax')">Too late!</md-error>
4855
<md-error *ngIf="resultPickerModel.hasError('mdDatepickerFilter')">Date unavailable!</md-error>
4956
</md-input-container>
50-
<md-datepicker
51-
#resultPicker
52-
[touchUi]="touch"
53-
[disabled]="datepickerDisabled"
54-
[startAt]="startAt"
55-
[startView]="yearView ? 'year' : 'month'">
56-
</md-datepicker>
5757
</p>
5858
<p>Last input: {{lastDateInput}}</p>
5959
<p>Last change: {{lastDateChange}}</p>
@@ -83,9 +83,9 @@ <h2>Input disabled datepicker</h2>
8383
<input mdInput [mdDatepicker]="datePicker1" [(ngModel)]="date" [min]="minDate" [max]="maxDate"
8484
[mdDatepickerFilter]="filterOdd ? dateFilter : null" [disabled]="true"
8585
placeholder="Input disabled">
86-
</md-input-container>
87-
<md-datepicker #datePicker1 [touchUi]="touch" [startAt]="startAt"
86+
<md-datepicker #datePicker1 [touchUi]="touch" [startAt]="startAt"
8887
[startView]="yearView ? 'year' : 'month'"></md-datepicker>
88+
</md-input-container>
8989
</p>
9090

9191
<h2>Input disabled, datepicker popup enabled</h2>
@@ -95,7 +95,7 @@ <h2>Input disabled, datepicker popup enabled</h2>
9595
<input mdInput disabled [mdDatepicker]="datePicker2" [(ngModel)]="date" [min]="minDate"
9696
[max]="maxDate" [mdDatepickerFilter]="filterOdd ? dateFilter : null"
9797
placeholder="Input disabled, datepicker enabled">
98+
<md-datepicker #datePicker2 [touchUi]="touch" [disabled]="false" [startAt]="startAt"
99+
[startView]="yearView ? 'year' : 'month'"></md-datepicker>
98100
</md-input-container>
99-
<md-datepicker #datePicker2 [touchUi]="touch" [disabled]="false" [startAt]="startAt"
100-
[startView]="yearView ? 'year' : 'month'"></md-datepicker>
101101
</p>

src/lib/autocomplete/autocomplete-trigger.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ import {Observable} from 'rxjs/Observable';
4040
import {MdOptionSelectionChange, MdOption} from '../core/option/option';
4141
import {ENTER, UP_ARROW, DOWN_ARROW, ESCAPE} from '../core/keyboard/keycodes';
4242
import {Directionality} from '../core/bidi/index';
43-
import {MdInputContainer, MdInputDirective} from '../input/input-container';
43+
import {MdFormField, MdInput} from '../input/input-container';
4444
import {Subscription} from 'rxjs/Subscription';
4545
import {merge} from 'rxjs/observable/merge';
4646
import {fromEvent} from 'rxjs/observable/fromEvent';
@@ -153,7 +153,7 @@ export class MdAutocompleteTrigger implements ControlValueAccessor, OnDestroy {
153153
private _changeDetectorRef: ChangeDetectorRef,
154154
@Inject(MD_AUTOCOMPLETE_SCROLL_STRATEGY) private _scrollStrategy,
155155
@Optional() private _dir: Directionality,
156-
@Optional() @Host() private _inputContainer: MdInputContainer,
156+
@Optional() @Host() private _inputContainer: MdFormField,
157157
@Optional() @Inject(DOCUMENT) private _document: any) {}
158158

159159
ngOnDestroy() {
@@ -411,8 +411,8 @@ export class MdAutocompleteTrigger implements ControlValueAccessor, OnDestroy {
411411
// If it's used in a Material container, we should set it through
412412
// the property so it can go through the change detection.
413413
if (this._inputContainer &&
414-
this._inputContainer._textFieldControl instanceof MdInputDirective) {
415-
this._inputContainer._textFieldControl.value = inputValue;
414+
this._inputContainer._control instanceof MdInput) {
415+
this._inputContainer._control.value = inputValue;
416416
} else {
417417
this._element.nativeElement.value = inputValue;
418418
}

src/lib/autocomplete/autocomplete.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import {Directionality, Direction} from '../core/bidi/index';
2323
import {Subscription} from 'rxjs/Subscription';
2424
import {ENTER, DOWN_ARROW, SPACE, UP_ARROW, ESCAPE} from '../core/keyboard/keycodes';
2525
import {MdOption} from '../core/option/option';
26-
import {MdInputContainer} from '../input/input-container';
26+
import {MdFormField} from '../input/input-container';
2727
import {Observable} from 'rxjs/Observable';
2828
import {Subject} from 'rxjs/Subject';
2929
import {createKeyboardEvent, dispatchFakeEvent, typeInElement} from '@angular/cdk/testing';
@@ -1417,7 +1417,7 @@ class SimpleAutocomplete implements OnDestroy {
14171417

14181418
@ViewChild(MdAutocompleteTrigger) trigger: MdAutocompleteTrigger;
14191419
@ViewChild(MdAutocomplete) panel: MdAutocomplete;
1420-
@ViewChild(MdInputContainer) inputContainer: MdInputContainer;
1420+
@ViewChild(MdFormField) inputContainer: MdFormField;
14211421
@ViewChildren(MdOption) options: QueryList<MdOption>;
14221422

14231423
states = [

src/lib/datepicker/datepicker-input.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ import {
3131
Validators
3232
} from '@angular/forms';
3333
import {Subscription} from 'rxjs/Subscription';
34-
import {MdInputContainer} from '../input/input-container';
34+
import {MdFormField} from '../input/input-container';
3535
import {DOWN_ARROW} from '../core/keyboard/keycodes';
3636
import {DateAdapter} from '../core/datetime/index';
3737
import {createMissingDateImplError} from './datepicker-errors';
@@ -212,7 +212,7 @@ export class MdDatepickerInput<D> implements AfterContentInit, ControlValueAcces
212212
private _renderer: Renderer2,
213213
@Optional() private _dateAdapter: DateAdapter<D>,
214214
@Optional() @Inject(MD_DATE_FORMATS) private _dateFormats: MdDateFormats,
215-
@Optional() private _mdInputContainer: MdInputContainer) {
215+
@Optional() private _mdInputContainer: MdFormField) {
216216
if (!this._dateAdapter) {
217217
throw createMissingDateImplError('DateAdapter');
218218
}

src/lib/input/index.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@
88

99
import {NgModule} from '@angular/core';
1010
import {
11-
MdErrorDirective,
11+
MdError,
1212
MdHint,
13-
MdInputContainer,
14-
MdInputDirective,
13+
MdFormField,
14+
MdInput,
1515
MdPlaceholder,
1616
MdPrefix,
1717
MdSuffix
@@ -23,10 +23,10 @@ import {PlatformModule} from '../core/platform/index';
2323

2424
@NgModule({
2525
declarations: [
26-
MdErrorDirective,
26+
MdError,
2727
MdHint,
28-
MdInputContainer,
29-
MdInputDirective,
28+
MdFormField,
29+
MdInput,
3030
MdPlaceholder,
3131
MdPrefix,
3232
MdSuffix,
@@ -37,10 +37,10 @@ import {PlatformModule} from '../core/platform/index';
3737
PlatformModule,
3838
],
3939
exports: [
40-
MdErrorDirective,
40+
MdError,
4141
MdHint,
42-
MdInputContainer,
43-
MdInputDirective,
42+
MdFormField,
43+
MdInput,
4444
MdPlaceholder,
4545
MdPrefix,
4646
MdSuffix,

src/lib/input/input-container-errors.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,22 +7,22 @@
77
*/
88

99
/** @docs-private */
10-
export function getMdInputContainerPlaceholderConflictError(): Error {
10+
export function getMdFormFieldPlaceholderConflictError(): Error {
1111
return Error('Placeholder attribute and child element were both specified.');
1212
}
1313

1414
/** @docs-private */
15-
export function getMdInputContainerUnsupportedTypeError(type: string): Error {
16-
return Error(`Input type "${type}" isn't supported by md-input-container.`);
15+
export function getMdInputUnsupportedTypeError(type: string): Error {
16+
return Error(`Input type "${type}" isn't supported by mdInput.`);
1717
}
1818

1919
/** @docs-private */
20-
export function getMdInputContainerDuplicatedHintError(align: string): Error {
20+
export function getMdFormFieldDuplicatedHintError(align: string): Error {
2121
return Error(`A hint was already declared for 'align="${align}"'.`);
2222
}
2323

2424
/** @docs-private */
25-
export function getMdInputContainerMissingMdInputError(): Error {
26-
return Error('md-input-container must contain an mdInput directive. ' +
27-
'Did you forget to add mdInput to the native input or textarea element?');
25+
export function getMdFormFieldMissingControlError(): Error {
26+
return Error('md-form-field must contain a MdFormFieldControl. ' +
27+
'Did you forget to add mdInput to the native input or textarea element?');
2828
}

src/lib/input/input-container.html

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,22 +5,22 @@
55
</div>
66

77
<div class="mat-input-infix">
8-
<ng-content selector="input, textarea"></ng-content>
8+
<ng-content></ng-content>
99

1010
<span class="mat-input-placeholder-wrapper">
1111
<label class="mat-input-placeholder"
12-
[attr.for]="_textFieldControl.getId()"
13-
[class.mat-empty]="_textFieldControl.isEmpty() && !_shouldAlwaysFloat"
12+
[attr.for]="_control.getId()"
13+
[class.mat-empty]="_control.isEmpty() && !_shouldAlwaysFloat"
1414
[class.mat-float]="_canPlaceholderFloat"
1515
[class.mat-accent]="color == 'accent'"
1616
[class.mat-warn]="color == 'warn'"
1717
*ngIf="_hasPlaceholder()">
1818
<ng-content select="md-placeholder, mat-placeholder"></ng-content>
19-
{{_textFieldControl.getPlaceholder()}}
19+
{{_control.getPlaceholder()}}
2020
<span
2121
class="mat-placeholder-required"
2222
aria-hidden="true"
23-
*ngIf="!hideRequiredMarker && _textFieldControl.isRequired()">*</span>
23+
*ngIf="!hideRequiredMarker && _control.isRequired()">*</span>
2424
</label>
2525
</span>
2626
</div>
@@ -31,7 +31,7 @@
3131
</div>
3232

3333
<div class="mat-input-underline" #underline
34-
[class.mat-disabled]="_textFieldControl.isDisabled()">
34+
[class.mat-disabled]="_control.isDisabled()">
3535
<span class="mat-input-ripple"
3636
[class.mat-accent]="color == 'accent'"
3737
[class.mat-warn]="color == 'warn'"></span>

src/lib/input/input-container.spec.ts

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@ import {
1212
import {By} from '@angular/platform-browser';
1313
import {NoopAnimationsModule} from '@angular/platform-browser/animations';
1414
import {MdInputModule} from './index';
15-
import {MdInputContainer, MdInputDirective} from './input-container';
15+
import {MdFormField, MdInput} from './input-container';
1616
import {Platform} from '../core/platform/platform';
1717
import {PlatformModule} from '../core/platform/index';
1818
import {wrappedErrorMessage, dispatchFakeEvent} from '@angular/cdk/testing';
1919
import {
20-
getMdInputContainerDuplicatedHintError,
21-
getMdInputContainerMissingMdInputError,
22-
getMdInputContainerPlaceholderConflictError
20+
getMdFormFieldDuplicatedHintError,
21+
getMdFormFieldMissingControlError,
22+
getMdFormFieldPlaceholderConflictError
2323
} from './input-container-errors';
2424
import {MD_PLACEHOLDER_GLOBAL_OPTIONS} from '../core/placeholder/placeholder-options';
2525
import {MD_ERROR_GLOBAL_OPTIONS, showOnDirtyErrorStateMatcher} from '../core/error/error-options';
@@ -73,8 +73,8 @@ describe('MdInputContainer without forms', function () {
7373
let fixture = TestBed.createComponent(MdInputContainerWithId);
7474
fixture.detectChanges();
7575

76-
let inputContainer = fixture.debugElement.query(By.directive(MdInputContainer))
77-
.componentInstance as MdInputContainer;
76+
let inputContainer = fixture.debugElement.query(By.directive(MdFormField))
77+
.componentInstance as MdFormField;
7878
expect(inputContainer.floatPlaceholder).toBe('auto',
7979
'Expected MdInputContainer to set floatingLabel to auto by default.');
8080
});
@@ -96,8 +96,8 @@ describe('MdInputContainer without forms', function () {
9696
let fixture = TestBed.createComponent(MdInputContainerWithId);
9797
fixture.detectChanges();
9898

99-
let inputContainer = fixture.debugElement.query(By.directive(MdInputContainer))
100-
.componentInstance as MdInputContainer;
99+
let inputContainer = fixture.debugElement.query(By.directive(MdFormField))
100+
.componentInstance as MdFormField;
101101
expect(inputContainer.floatPlaceholder).toBe('always',
102102
'Expected MdInputContainer to set floatingLabel to always from global option.');
103103
});
@@ -236,40 +236,40 @@ describe('MdInputContainer without forms', function () {
236236
let fixture = TestBed.createComponent(MdInputContainerInvalidHintTestController);
237237

238238
expect(() => fixture.detectChanges()).toThrowError(
239-
wrappedErrorMessage(getMdInputContainerDuplicatedHintError('start')));
239+
wrappedErrorMessage(getMdFormFieldDuplicatedHintError('start')));
240240
});
241241

242242
it('validates there\'s only one hint label per side (attribute)', () => {
243243
let fixture = TestBed.createComponent(MdInputContainerInvalidHint2TestController);
244244

245245
expect(() => fixture.detectChanges()).toThrowError(
246-
wrappedErrorMessage(getMdInputContainerDuplicatedHintError('start')));
246+
wrappedErrorMessage(getMdFormFieldDuplicatedHintError('start')));
247247
});
248248

249249
it('validates there\'s only one placeholder', () => {
250250
let fixture = TestBed.createComponent(MdInputContainerInvalidPlaceholderTestController);
251251

252252
expect(() => fixture.detectChanges()).toThrowError(
253-
wrappedErrorMessage(getMdInputContainerPlaceholderConflictError()));
253+
wrappedErrorMessage(getMdFormFieldPlaceholderConflictError()));
254254
});
255255

256256
it('validates that mdInput child is present', () => {
257257
let fixture = TestBed.createComponent(MdInputContainerMissingMdInputTestController);
258258

259259
expect(() => fixture.detectChanges()).toThrowError(
260-
wrappedErrorMessage(getMdInputContainerMissingMdInputError()));
260+
wrappedErrorMessage(getMdFormFieldMissingControlError()));
261261
});
262262

263263
it('validates that mdInput child is present after initialization', async(() => {
264264
let fixture = TestBed.createComponent(MdInputContainerWithNgIf);
265265

266266
expect(() => fixture.detectChanges()).not.toThrowError(
267-
wrappedErrorMessage(getMdInputContainerMissingMdInputError()));
267+
wrappedErrorMessage(getMdFormFieldMissingControlError()));
268268

269269
fixture.componentInstance.renderInput = false;
270270

271271
expect(() => fixture.detectChanges()).toThrowError(
272-
wrappedErrorMessage(getMdInputContainerMissingMdInputError()));
272+
wrappedErrorMessage(getMdFormFieldMissingControlError()));
273273
}));
274274

275275
it('validates the type', () => {
@@ -580,8 +580,8 @@ describe('MdInputContainer without forms', function () {
580580

581581
fixture.detectChanges();
582582

583-
const inputContainer = fixture.debugElement.query(By.directive(MdInputContainer));
584-
const containerInstance = inputContainer.componentInstance as MdInputContainer;
583+
const inputContainer = fixture.debugElement.query(By.directive(MdFormField));
584+
const containerInstance = inputContainer.componentInstance as MdFormField;
585585
const placeholder = inputContainer.nativeElement.querySelector('.mat-input-placeholder');
586586

587587
expect(containerInstance.floatPlaceholder).toBe('auto');
@@ -638,8 +638,8 @@ describe('MdInputContainer without forms', function () {
638638
let fixture = TestBed.createComponent(MdInputContainerTextTestController);
639639
fixture.detectChanges();
640640

641-
let input = fixture.debugElement.query(By.directive(MdInputDirective))
642-
.injector.get<MdInputDirective>(MdInputDirective);
641+
let input = fixture.debugElement.query(By.directive(MdInput))
642+
.injector.get<MdInput>(MdInput);
643643
let container = fixture.debugElement.query(By.css('md-input-container')).nativeElement;
644644

645645
// Call the focus handler directly to avoid flakyness where
@@ -944,8 +944,8 @@ describe('MdInputContainer with forms', () => {
944944
let fixture = TestBed.createComponent(MdInputContainerWithFormControl);
945945
fixture.detectChanges();
946946

947-
let input = fixture.debugElement.query(By.directive(MdInputDirective))
948-
.injector.get<MdInputDirective>(MdInputDirective);
947+
let input = fixture.debugElement.query(By.directive(MdInput))
948+
.injector.get<MdInput>(MdInput);
949949

950950
expect(input.value).toBeFalsy();
951951

0 commit comments

Comments
 (0)