Fix no operation tests for datepicker

Author: devversion

src/lib/datepicker/datepicker.spec.ts

@@ -28,7 +28,6 @@ import {MatDatepickerInput} from './datepicker-input';
 import {MatDatepickerToggle} from './datepicker-toggle';
 import {MatDatepickerIntl, MatDatepickerModule} from './index';
 
-
 describe('MatDatepicker', () => {
   afterEach(inject([OverlayContainer], (container: OverlayContainer) => {
     container.getContainerElement().parentNode!.removeChild(container.getContainerElement());
@@ -104,7 +103,7 @@ describe('MatDatepicker', () => {
             .not.toBeNull();
       });
 
-      it('should open datepicker if opened input is set to true', async(() => {
+      it('should open datepicker if opened input is set to true', () => {
         testComponent.opened = true;
         fixture.detectChanges();
 
@@ -113,10 +112,8 @@ describe('MatDatepicker', () => {
         testComponent.opened = false;
         fixture.detectChanges();
 
-        fixture.whenStable().then(() => {
-          expect(document.querySelector('.mat-datepicker-content')).toBeNull();
-        });
-      }));
+        expect(document.querySelector('.mat-datepicker-content')).toBeNull();
+      });
 
       it('open in disabled mode should not open the calendar', () => {
         testComponent.disabled = true;
@@ -156,9 +153,7 @@ describe('MatDatepicker', () => {
         testComponent.datepicker.close();
         fixture.detectChanges();
 
-        fixture.whenStable().then(() => {
-          expect(parseInt(getComputedStyle(popup).height as string)).toBe(0);
-        });
+        expect(parseInt(getComputedStyle(popup).height as string)).toBe(0);
       });
 
       it('should close the popup when pressing ESCAPE', () => {
@@ -182,7 +177,7 @@ describe('MatDatepicker', () => {
             .toBe(true, 'Expected default ESCAPE action to be prevented.');
       });
 
-      it('close should close dialog', () => {
+      it('close should close dialog', async(() => {
         testComponent.touch = true;
         fixture.detectChanges();
 
@@ -197,9 +192,9 @@ describe('MatDatepicker', () => {
         fixture.whenStable().then(() => {
           expect(document.querySelector('mat-dialog-container')).toBeNull();
         });
-      });
+      }));
 
-      it('setting selected should update input and close calendar', () => {
+      it('setting selected should update input and close calendar', async(() => {
         testComponent.touch = true;
         fixture.detectChanges();
 
@@ -217,12 +212,13 @@ describe('MatDatepicker', () => {
           expect(document.querySelector('mat-dialog-container')).toBeNull();
           expect(testComponent.datepickerInput.value).toEqual(new Date(2020, JAN, 2));
         });
-      });
+      }));
 
       it('clicking the currently selected date should close the calendar ' +
           'without firing selectedChanged', () => {
         const selectedChangedSpy =
             spyOn(testComponent.datepicker.selectedChanged, 'emit').and.callThrough();
+
         for (let changeCount = 1; changeCount < 3; changeCount++) {
           const currentDay = changeCount;
           testComponent.datepicker.open();
@@ -236,11 +232,9 @@ describe('MatDatepicker', () => {
           fixture.detectChanges();
         }
 
-        fixture.whenStable().then(() => {
-          expect(selectedChangedSpy.calls.count()).toEqual(1);
-          expect(document.querySelector('mat-dialog-container')).toBeNull();
-          expect(testComponent.datepickerInput.value).toEqual(new Date(2020, JAN, 2));
-        });
+        expect(selectedChangedSpy.calls.count()).toEqual(1);
+        expect(document.querySelector('mat-dialog-container')).toBeNull();
+        expect(testComponent.datepickerInput.value).toEqual(new Date(2020, JAN, 2));
       });
 
       it('startAt should fallback to input value', () => {
@@ -488,7 +482,7 @@ describe('MatDatepicker', () => {
         expect(inputEl.classList).toContain('ng-touched');
       });
 
-      it('should mark input touched on calendar selection', () => {
+      it('should mark input touched on calendar selection', async(() => {
         let inputEl = fixture.debugElement.query(By.css('input')).nativeElement;
 
         expect(inputEl.classList).toContain('ng-untouched');
@@ -501,7 +495,7 @@ describe('MatDatepicker', () => {
 
           expect(inputEl.classList).toContain('ng-touched');
         });
-      });
+      }));
     });
 
     describe('datepicker with formControl', () => {
@@ -711,7 +705,7 @@ describe('MatDatepicker', () => {
         expect(testComponent.datepicker._maxDate).toEqual(new Date(2020, JAN, 1));
       });
 
-      it('should mark invalid when value is before min', () => {
+      it('should mark invalid when value is before min', async(() => {
         testComponent.date = new Date(2009, DEC, 31);
         fixture.detectChanges();
 
@@ -721,9 +715,9 @@ describe('MatDatepicker', () => {
           expect(fixture.debugElement.query(By.css('input')).nativeElement.classList)
               .toContain('ng-invalid');
         });
-      });
+      }));
 
-      it('should mark invalid when value is after max', () => {
+      it('should mark invalid when value is after max', async(() => {
         testComponent.date = new Date(2020, JAN, 2);
         fixture.detectChanges();
 
@@ -733,9 +727,9 @@ describe('MatDatepicker', () => {
           expect(fixture.debugElement.query(By.css('input')).nativeElement.classList)
               .toContain('ng-invalid');
         });
-      });
+      }));
 
-      it('should not mark invalid when value equals min', () => {
+      it('should not mark invalid when value equals min', async(() => {
         testComponent.date = testComponent.datepicker._minDate;
         fixture.detectChanges();
 
@@ -745,9 +739,9 @@ describe('MatDatepicker', () => {
           expect(fixture.debugElement.query(By.css('input')).nativeElement.classList)
               .not.toContain('ng-invalid');
         });
-      });
+      }));
 
-      it('should not mark invalid when value equals max', () => {
+      it('should not mark invalid when value equals max', async(() => {
         testComponent.date = testComponent.datepicker._maxDate;
         fixture.detectChanges();
 
@@ -757,9 +751,9 @@ describe('MatDatepicker', () => {
           expect(fixture.debugElement.query(By.css('input')).nativeElement.classList)
               .not.toContain('ng-invalid');
         });
-      });
+      }));
 
-      it('should not mark invalid when value is between min and max', () => {
+      it('should not mark invalid when value is between min and max', async(() => {
         testComponent.date = new Date(2010, JAN, 2);
         fixture.detectChanges();
 
@@ -769,7 +763,7 @@ describe('MatDatepicker', () => {
           expect(fixture.debugElement.query(By.css('input')).nativeElement.classList)
               .not.toContain('ng-invalid');
         });
-      });
+      }));
     });
 
     describe('datepicker with filter and validation', () => {
@@ -1057,17 +1051,23 @@ describe('MatDatepicker', () => {
       input = fixture.nativeElement.querySelector('input') as HTMLInputElement;
     }));
 
-    it('should have the correct input value even when inverted date format', () => {
+    it('should have the correct input value even when inverted date format', async(() => {
+      if (typeof Intl === 'undefined') {
+        // Skip this test if the internationalization API is not supported in the current
+        // browser. Browsers like Safari 9 do not support the "Intl" API.
+        return;
+      }
+
       let selected = new Date(2017, SEP, 1);
       testComponent.date = selected;
       fixture.detectChanges();
 
       fixture.whenStable().then(() => {
         fixture.detectChanges();
-        expect(input.value).toBe('01.09.2017');
+        expect(input.value).toBe('1.9.2017');
         expect(testComponent.datepickerInput.value).toBe(selected);
       });
-    });
+    }));
   });
 });