Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth-guard): Adding in modular auth guards #3001

Merged
merged 6 commits into from
Oct 8, 2021
Merged

feat(auth-guard): Adding in modular auth guards #3001

merged 6 commits into from
Oct 8, 2021

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Oct 7, 2021 •
edited
Loading

  • Adding modular auth guards
  • Flushing out some basic tests
  • Refactored how isSupported is handled
  • Firestore wasn't passing the injector, need tests for this too
  • Fixed the version check on firebase-tools
  • Fixed firebase-tools project creation
  • Cleaned up some of the error messaging

TODO:

  • Firestore/lite is having troubles
  • Clean up the isSupported error message
  • Reexport isSupported

@google-cla google-cla bot added the cla: yes label Oct 7, 2021
@jamesdaniels jamesdaniels merged commit 3ae6ce5 into master Oct 8, 2021
@jamesdaniels jamesdaniels deleted the auth-guard branch October 8, 2021 05:33
@byrondover
Copy link
Contributor

Brilliant, thank you James!! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesdaniels @byrondover