build: ensure compiler is properly picked up as runtime dep of compiler-cli

Currently when linking the `@angular/compiler-cli` package, the peer
dependency to `compiler` is not resolved and we are trying to make the
compiler dependency available via `data`. This is unidiomatic and
brittle. This commit fixes this.

Author: devversion

.aspect/rules/external_repository_action_cache/npm_translate_lock_MzA5NzUwNzMx

@@ -1,12 +1,12 @@
 # @generated
 # Input hashes for repository rule npm_translate_lock(name = "npm2", pnpm_lock = "@//:pnpm-lock.yaml").
 # This file should be checked into version control along with the pnpm-lock.yaml file.
-.npmrc=-1406867100
+.npmrc=-151232324
 adev/shared-docs/pipeline/api-gen/package.json=939673974
 package.json=1801177040
-packages/compiler-cli/package.json=-1344632265
+packages/compiler-cli/package.json=-1765181548
 packages/compiler/package.json=1190056499
-pnpm-lock.yaml=522942070
+pnpm-lock.yaml=-6025827
 pnpm-workspace.yaml=-1822660674
 tools/bazel/rules_angular_store/package.json=-239561259
 yarn.lock=2018509044

.npmrc

@@ -9,4 +9,6 @@ hoist=false
 # Avoid pnpm auto-installing peer dependencies. We want to be explicit about our versions used
 # for peer dependencies, avoiding potential mismatches. In addition, it ensures we can continue
 # to rely on peer dependency placeholders substituted via Bazel.
-auto-install-peers=false
+# TODO(devversion): Temporarily during migration this is flipped as we can't have `workspace:*` deps
+# in the `package.json` also processed by Yarn.
+auto-install-peers=true

packages/compiler-cli/BUILD.bazel

@@ -149,11 +149,6 @@ pkg_npm(
 npm_package(
     name = "pkg",
     srcs = [":npm_package"],
-    data = [
-        # Needed because compiler is a dev dependency (to satisfy the peer dependency)
-        # and `rules_js` only makes transitive production dependencies available.
-        ":node_modules/@angular/compiler",
-    ],
     replace_prefixes = {
         "npm_package/": "",
     },

packages/compiler-cli/package.json

@@ -60,9 +60,6 @@
       "optional": true
     }
   },
-  "devDependencies": {
-    "@angular/compiler": "workspace:*"
-  },
   "repository": {
     "type": "git",
     "url": "https://github.com/angular/angular.git",