$resource POST removing trailing slash

[msurdi]

I have a module where I define a service like this:

.factory("Charts", function ($resource) {
return $resource("/api/charts/:chartId", {
}, {});
})

Then, on the controller I do:

var chart = new Charts({
name:$scope.name,
query:$scope.query,
since:$scope.since,
since_unit:$scope.since_unit,
interval:$scope.interval
}
);
chart.$save();

And on the server I'm receiving the POST to /api/charts instead of /api/charts/ that is what (I think) it should be.

There is a discussion in the list:

https://groups.google.com/forum/?fromgroups#!topic/angular/taypgj_D3YQ

[umurkontaci]

Pull request on this issue: https://github.com/angular/angular.js/pull/1064/files

[dandoyon]

we just ran into this with django, it was a bit of a tussel, with angular stripping off the slash and django (by default) was adding slash it back end and doing a redirect. Even after changing django default, I ran into an inconsistency with django-tastypie and ended up modifying ngResource to append a slash to make all parties happy.

a little differen than fastreload's

return url + "/" + (query.length ? '?' + query.join('&') : '');

I think maybe an param option might be nice.

--thx

dan

[umurkontaci]

I have done a quick hack on the issue but what I think is that frameworks should treat urls as is. Adding or removing a character from url actually means creating a completely new url and hoping that server will understand what we want.

[dandoyon]

I think the convenience of providing the hash with bind elements (as opposed to having a url template), means, that angular needs to muck with the url. I think they tried to cover too many cases and instead should probably just tell the user. What the url will look like in the various cases or provide options to dictate what should happen. IMHO

[umurkontaci]

Yes, but they could also make their internal interpretation of the urls and use the original url while contacting server. I have not examined the inner workings of url interpretation and routing yet this still does not legitimize changing urls without explicit order from user/coder.

Each server can have different types of interpretation urls and a client side framework should be able to communicate with them with no hassle or source changing. For example, Django has APPEND_SLASH setting which uses HTTP 302 redirection to append slash to urls without slash. This works with GET method but not with others (POST,PUT,DELETE) because redirection cannot and will not pass the data to the new URL.

[dandoyon]

I think these are great points to bring up. Don't know if you saw but there was a fairly long thread (a number of months ago) on ngResource rewrite and request from comments from Misko. Given the diverse response, I he decided to table things until future time.

[umurkontaci]

I haven't seen that thread, I am also not using angularjs for that long time, yet the claims that I have said are not design philosophies which is not related to a particular framework (as you said). Hopefully developers will see this issue and change their designs until new development cycle.

[stryderjzw]

Is there any more discussion on this? It would seem strange that the framework would enforce a certain type of url.

[umurkontaci]

Not that I know. No active developers have responded to this issue yet. I think that they would agree to that it is wrong to enforce a certain type of url but this part of the framework (ngResource, http) might not be loosely coupled with the rest of the framework and it may require more than a couple of changes for it to work. But that's just a hopeful assumption.

[mhevery]

There are many deficiencies in $resource. We are trying to figure out what
to do with it. in the meantime we recommend that you create resources
manually, which gives you full control over everything.

See:
http://stackoverflow.com/questions/11850025/recommended-way-of-getting-data-from-the-server/11850027#comment15909222_11850027

On Tue, Aug 21, 2012 at 4:20 AM, Umur Kontacı notifications@github.comwrote:

Not that I know. No active developers have responded to this issue yet. I
think that they would agree to that it is wrong to enforce a certain type
of url but this part of the framework (ngResource, http) might not be
loosely coupled with the rest of the framework and it may require more than
a couple of changes for it to work. But that's just a hopeful assumption.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/992#issuecomment-7898116.

[umurkontaci]

That would be a proper workaround meanwhile. Thanks for the heads up

[stryderjzw]

Thanks for the responses! Sorry to ask this here, but following the example, Book is undefined for me in my controller. Any suggestions?

[mhevery]

@stryderjzw the factory is missing return Book, I updated the SE.