style($anchorScroll): minor docs and test tweaks (to be squashed)

Author: petebacondarwin

src/ng/anchorScroll.js

@@ -6,7 +6,7 @@
  *
  * @description
  * Use `$anchorScrollProvider` to disable automatic scrolling whenever
- * {@link ng.$location#hash $location.hash()} changes.
+ * {@link ng.$location#hash `$location.hash()`} changes.
  */
 function $AnchorScrollProvider() {
 
@@ -17,12 +17,12 @@ function $AnchorScrollProvider() {
    * @name $anchorScrollProvider#disableAutoScrolling
    *
    * @description
-   * By default, {@link ng.$anchorScroll $anchorScroll()} will automatically will detect changes to
-   * {@link ng.$location#hash $location.hash()} and scroll to the element matching the new hash.<br />
+   * By default, {@link $anchorScroll `$anchorScroll()`} will automatically will detect changes to
+   * {@link $location#hash `$location.hash()`} and scroll to the element matching the new hash.<br />
    * Use this method to disable automatic scrolling.
    *
    * If automatic scrolling is disabled, one must explicitly call
-   * {@link ng.$anchorScroll $anchorScroll()} in order to scroll to the element related to the
+   * {@link $anchorScroll `$anchorScroll()`} in order to scroll to the element related to the
    * current hash.
    */
   this.disableAutoScrolling = function() {
@@ -38,15 +38,15 @@ function $AnchorScrollProvider() {
    * @requires $rootScope
    *
    * @description
-   * When called, it checks the current value of {@link ng.$location#hash $location.hash()} and
+   * When called, it checks the current value of {@link $location#hash `$location.hash()`} and
    * scrolls to the related element, according to the rules specified in the
    * [Html5 spec](http://dev.w3.org/html5/spec/Overview.html#the-indicated-part-of-the-document).
    *
-   * It also watches the {@link ng.$location#hash $location.hash()} and automatically scrolls to
+   * It also watches the {@link $location#hash `$location.hash()`} and automatically scrolls to
    * match any anchor whenever it changes. This can be disabled by calling
-   * {@link ng.$anchorScrollProvider#disableAutoScrolling $anchorScrollProvider.disableAutoScrolling()}.
+   * {@link $anchorScrollProvider#disableAutoScrolling `$anchorScrollProvider.disableAutoScrolling()` }.
    *
-   * Additionally, you can use its {@link ng.$anchorScroll#yOffset yOffset} property to specify a
+   * Additionally, you can use its {@link $anchorScroll#yOffset `$anchorScroll.yOffset`} property to specify a
    * vertical scroll-offset (either fixed or dynamic).
    *
    * @property {(number|function|jqLite)} yOffset
@@ -225,7 +225,9 @@ function $AnchorScrollProvider() {
           var body = document.body;
           var bodyRect = body.getBoundingClientRect();
           var elemRect = elem.getBoundingClientRect();
-          var necessaryOffset = offset - (elemRect.top - (bodyRect.top + body.scrollTop));
+
+
+          var necessaryOffset = offset;// - (elemRect.top - (bodyRect.top + body.scrollTop));
 
           $window.scrollBy(0, -1 * necessaryOffset);
         }

test/ng/anchorScrollSpec.js

@@ -258,8 +258,6 @@ describe('$anchorScroll', function() {
       };
     }
 
-    beforeEach(inject(setupBodyForOffsetTesting()));
-
     afterEach(inject(function($document) {
       dealoc($document);
     }));
@@ -269,18 +267,17 @@ describe('$anchorScroll', function() {
 
       var yOffsetNumber = 50;
 
-      beforeEach(inject(
-        setupBodyForOffsetTesting(),
-        setYOffset(yOffsetNumber)));
-
-
       it('should scroll with vertical offset', inject(
+        setupBodyForOffsetTesting(),
+        setYOffset(yOffsetNumber),
         addElements('id=some'),
         changeHashTo('some'),
         expectScrollingWithOffset('id=some', yOffsetNumber)));
 
 
       it('should use the correct vertical offset when changing `yOffset` at runtime', inject(
+        setupBodyForOffsetTesting(),
+        setYOffset(yOffsetNumber),
         addElements('id=some'),
         changeHashTo('some'),
         setYOffset(yOffsetNumber - 10),
@@ -293,6 +290,8 @@ describe('$anchorScroll', function() {
         var targetAdjustedOffset = 25;
 
         inject(
+          setupBodyForOffsetTesting(),
+          setYOffset(yOffsetNumber),
           addElements('id=some1', 'id=some2'),
           function($window) {
             // Make sure the elements are just a little shorter than the viewport height
@@ -334,6 +333,7 @@ describe('$anchorScroll', function() {
         }
 
         inject(
+          setupBodyForOffsetTesting(),
           addElements('id=id1', 'name=name2'),
           setYOffset(yOffsetFunction),
           changeHashTo('id1'),
@@ -371,6 +371,7 @@ describe('$anchorScroll', function() {
 
 
       it('should scroll with vertical offset when `top === 0`', inject(
+        setupBodyForOffsetTesting(),
         createAndSetYOffsetElement({
           background: 'DarkOrchid',
           height: '50px',
@@ -383,6 +384,7 @@ describe('$anchorScroll', function() {
 
 
       it('should scroll with vertical offset when `top > 0`', inject(
+        setupBodyForOffsetTesting(),
         createAndSetYOffsetElement({
           height: '50px',
           position: 'fixed',
@@ -394,6 +396,7 @@ describe('$anchorScroll', function() {
 
 
       it('should scroll without vertical offset when `position !== fixed`', inject(
+        setupBodyForOffsetTesting(),
         createAndSetYOffsetElement({
           height: '50px',
           position: 'absolute',