fix(input): update $viewValue when cleared

- Fix when user clicks clear button in an input element in IE, $viewValue not being correctly updated

Author: wesleycho

src/ng/directive/input.js

@@ -1103,11 +1103,11 @@ function stringBasedInputType(ctrl) {
 }
 
 function textInputType(scope, element, attr, ctrl, $sniffer, $browser) {
-  baseInputType(scope, element, attr, ctrl, $sniffer, $browser);
+  baseInputType(scope, element, attr, ctrl, $sniffer, $browser, 'text');
   stringBasedInputType(ctrl);
 }
 
-function baseInputType(scope, element, attr, ctrl, $sniffer, $browser) {
+function baseInputType(scope, element, attr, ctrl, $sniffer, $browser, inputType) {
   var type = lowercase(element[0].type);
 
   // In composition mode, users are still inputing intermediate text buffer,
@@ -1126,7 +1126,11 @@ function baseInputType(scope, element, attr, ctrl, $sniffer, $browser) {
     });
   }
 
-  var timeout;
+  var timeout, oldVal;
+  var viewValueUpdated = true, msieInput = msie >= 10 && msie <= 11;
+  if (msieInput && inputType === 'text') {
+    oldVal = element.val();
+  }
 
   var listener = function(ev) {
     if (timeout) {
@@ -1152,10 +1156,18 @@ function baseInputType(scope, element, attr, ctrl, $sniffer, $browser) {
     }
   };
 
+  function ieListener(ev) {
+    var val = element.val();
+    if (val === oldVal && !viewValueUpdated) return;
+    oldVal = val;
+    viewValueUpdated = false;
+    listener(ev);
+  }
+
   // if the browser does support "input" event, we are fine - except on IE9 which doesn't fire the
   // input event on backspace, delete or cut
   if ($sniffer.hasEvent('input')) {
-    element.on('input', listener);
+    element.on('input', msie ? ieListener : listener);
   } else {
     var deferListener = function(ev, input, origValue) {
       if (!timeout) {
@@ -1212,6 +1224,10 @@ function baseInputType(scope, element, attr, ctrl, $sniffer, $browser) {
     // Workaround for Firefox validation #12102.
     var value = ctrl.$isEmpty(ctrl.$viewValue) ? '' : ctrl.$viewValue;
     if (element.val() !== value) {
+      // Workaround for IE 10 & 11 input updates #11193
+      if (msieInput) {
+        viewValueUpdated = true;
+      }
       element.val(value);
     }
   };

src/ng/sniffer.js

@@ -73,7 +73,7 @@ function $SnifferProvider() {
         // when cut operation is performed.
         // IE10+ implements 'input' event but it erroneously fires under various situations,
         // e.g. when placeholder changes, or a form is focused.
-        if (event === 'input' && msie <= 11) return false;
+        if (event === 'input' && msie <= 9) return false;
 
         if (isUndefined(eventSupport[event])) {
           var divElm = document.createElement('div');

test/ng/snifferSpec.js

@@ -135,7 +135,7 @@ describe('$sniffer', function() {
       // IE10+ implementation is fubared when mixed with placeholders
       mockDivElement = {oninput: noop};
 
-      expect($sniffer.hasEvent('input')).toBe(!(msie && msie <= 11));
+      expect($sniffer.hasEvent('input')).toBe(!(msie && msie <= 9));
     });
   });