fixup! fix(interpolate): do not create directives for constant media URL attributes

Author: petebacondarwin

test/ng/compileSpec.js

@@ -12093,32 +12093,8 @@ describe('$compile', function() {
       expect(element.attr('test6')).toBe('Misko');
     }));
 
-    describe('when an attribute has a dash-separated name', function() {
-      it('should work with different prefixes', inject(function() {
-        $rootScope.name = 'JamieMason';
-        element = $compile('<span ng:attr:dash-test="{{name}}" ng-Attr-dash-test2="{{name}}" ng_Attr_dash-test3="{{name}}"></span>')($rootScope);
-        expect(element.attr('dash-test')).toBeUndefined();
-        expect(element.attr('dash-test2')).toBeUndefined();
-        expect(element.attr('dash-test3')).toBeUndefined();
-        $rootScope.$digest();
-        expect(element.attr('dash-test')).toBe('JamieMason');
-        expect(element.attr('dash-test2')).toBe('JamieMason');
-        expect(element.attr('dash-test3')).toBe('JamieMason');
-      }));
-
-      it('should work if they are prefixed with x- or data-', inject(function() {
-        $rootScope.name = 'JamieMason';
-        element = $compile('<span data-ng-attr-dash-test2="{{name}}" x-ng-attr-dash-test3="{{name}}" data-ng:attr-dash-test4="{{name}}"></span>')($rootScope);
-        expect(element.attr('dash-test2')).toBeUndefined();
-        expect(element.attr('dash-test3')).toBeUndefined();
-        expect(element.attr('dash-test4')).toBeUndefined();
-        $rootScope.$digest();
-        expect(element.attr('dash-test2')).toBe('JamieMason');
-        expect(element.attr('dash-test3')).toBe('JamieMason');
-        expect(element.attr('dash-test4')).toBe('JamieMason');
-      }));
-
-      it('should work with img[src]', inject(function() {
+    describe('with media url attributes', function() {
+      it('should work with interpolated ng-attr-src', inject(function() {
         $rootScope.name = 'some-image.png';
         element = $compile('<img ng-attr-src="{{name}}">')($rootScope);
         expect(element.attr('src')).toBeUndefined();
@@ -12131,7 +12107,7 @@ describe('$compile', function() {
         expect(element.attr('src')).toBe('other-image.png');
       }));
 
-      it('should work with img[data-src]', inject(function() {
+      it('should work with interpolated ng-attr-data-src', inject(function() {
         $rootScope.name = 'some-image.png';
         element = $compile('<img ng-attr-data-src="{{name}}">')($rootScope);
         expect(element.attr('data-src')).toBeUndefined();
@@ -12144,7 +12120,7 @@ describe('$compile', function() {
         expect(element.attr('data-src')).toBe('other-image.png');
       }));
 
-      it('should compile img with constant [src]-attribute and [ng-attr-data-src] attribute', inject(function() {
+      it('should work alongside constant [src]-attribute and [ng-attr-data-src] attributes', inject(function() {
         $rootScope.name = 'some-image.png';
         element = $compile('<img src="constant.png" ng-attr-data-src="{{name}}">')($rootScope);
         expect(element.attr('data-src')).toBeUndefined();
@@ -12158,6 +12134,32 @@ describe('$compile', function() {
         expect(element.attr('src')).toBe('constant.png');
         expect(element.attr('data-src')).toBe('other-image.png');
       }));
+    });
+
+    describe('when an attribute has a dash-separated name', function() {
+      it('should work with different prefixes', inject(function() {
+        $rootScope.name = 'JamieMason';
+        element = $compile('<span ng:attr:dash-test="{{name}}" ng-Attr-dash-test2="{{name}}" ng_Attr_dash-test3="{{name}}"></span>')($rootScope);
+        expect(element.attr('dash-test')).toBeUndefined();
+        expect(element.attr('dash-test2')).toBeUndefined();
+        expect(element.attr('dash-test3')).toBeUndefined();
+        $rootScope.$digest();
+        expect(element.attr('dash-test')).toBe('JamieMason');
+        expect(element.attr('dash-test2')).toBe('JamieMason');
+        expect(element.attr('dash-test3')).toBe('JamieMason');
+      }));
+
+      it('should work if they are prefixed with x- or data-', inject(function() {
+        $rootScope.name = 'JamieMason';
+        element = $compile('<span data-ng-attr-dash-test2="{{name}}" x-ng-attr-dash-test3="{{name}}" data-ng:attr-dash-test4="{{name}}"></span>')($rootScope);
+        expect(element.attr('dash-test2')).toBeUndefined();
+        expect(element.attr('dash-test3')).toBeUndefined();
+        expect(element.attr('dash-test4')).toBeUndefined();
+        $rootScope.$digest();
+        expect(element.attr('dash-test2')).toBe('JamieMason');
+        expect(element.attr('dash-test3')).toBe('JamieMason');
+        expect(element.attr('dash-test4')).toBe('JamieMason');
+      }));
 
       it('should keep attributes ending with -start single-element directives', function() {
         module(function($compileProvider) {