test(ci): NODE 6 continuous integration #570
Conversation
| @@ -17,7 +17,7 @@ | |||
| "url": "https://github.com/angular/angular-cli.git" | |||
| }, | |||
| "engines": { | |||
| "node": ">= 4.1.0" | |||
| "node": ">= 5.0.0" | |||
There was a problem hiding this comment.
I don't think we want to exclude anyone still on node 4 even though were not running tests for it.
There was a problem hiding this comment.
@hansl said that we don't support node 4 anymore.
There was a problem hiding this comment.
I thought you were asking about if we still tested on node 4. It's fine to keep node 4.1, unless there's a technical problem with this PR.
jkuri
force-pushed
the
node6
branch
6 times, most recently
from
f9c5b6c to
3de6cc4
Compare
| @@ -65,7 +65,7 @@ | |||
| "exists-sync": "0.0.3", | |||
| "minimatch": "^3.0.0", | |||
| "mocha": "^2.4.5", | |||
| "mock-fs": "^3.8.0", | |||
| "mock-fs": "^3.9.0", | |||
There was a problem hiding this comment.
Why does this dependency need updating?
There was a problem hiding this comment.
Mike has told me it was to support node 6.
There was a problem hiding this comment.
This was the update I was waiting for, before it was not supporting node6.
|
Lgtm if it passes tests. Seems to have an issue with OSX. |
jkuri
force-pushed
the
node6
branch
21 times, most recently
from
cc02469 to
cfaac57
Compare
jkuri
force-pushed
the
node6
branch
6 times, most recently
from
9dc0b79 to
f30100f
Compare
|
Closing. @hansl will take over of this. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.