Skip to content

DOCS (guide): change Generating Components, Directives, Pipes and Services section #5470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

elmeerr
Copy link
Contributor

@elmeerr elmeerr commented Mar 17, 2017

Change in a update version of README to create a new PR (as suggest by Brocco)

Change in a update version of README to create a new PR (as suggest by Brocco)
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change please, otherwise LGTM.

README.md Outdated
angular-cli will add reference to `components`, `directives` and `pipes` automatically in the `app.module.ts`. If you need to add this references to another custom module, follow this steps:

1. `ng g module newModule` to create a new module
2. call `ng g component new-module/newComponent`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change newComponent and newModule to dash-case instead? That's how we show these overall in the documentation.

@elmeerr
Copy link
Contributor Author

elmeerr commented Mar 29, 2017

@filipesilva done 😃

filipesilva pushed a commit that referenced this pull request May 8, 2017
Change in a update version of README to create a new PR (as suggest by Brocco)

Close #5470
filipesilva pushed a commit that referenced this pull request May 8, 2017
Change in a update version of README to create a new PR (as suggest by Brocco)

Close #5470
filipesilva pushed a commit that referenced this pull request May 8, 2017
Change in a update version of README to create a new PR (as suggest by Brocco)

Close #5470
@hansl hansl closed this in 31fbf00 May 9, 2017
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this pull request Apr 23, 2018
Change in a update version of README to create a new PR (as suggest by Brocco)

Close angular#5470
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants