Correct forkChecker ats config option to speed up reloads #3008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The karma plugin is currently overwriting configuration set in karma.conf.js instead of merging existing values. This fix will set defaults but not overwrite existing configuration.
…r#1814) Add watchOptions to webpackDevServerConfiguration to conditionally enable polling option in watchpack Remove additional blank lines from end of serve-watchpack.ts so that only one is remaining
Fixed typo (removed extra 'to') and added colon to match other steps in global installation instructions. Close angular#2190
This commit fixes README example of including Bootstrap dependency in generated project in that way that Bootstrap CSS dependency is moved up - to be the first in build bundle. The reason behind this change is that Bootstrap comes with reset CSS code and globals that are intended to be global unless reset and changed by cascading file - here style.css. Thanks! Close angular#2197
Also adding a new package, webpack, which is a plugin and loader for webpack that adds support for AoT. It is behind a `--aot` flag in the CLI that is supported by build and serve.
* chore(npm): updated webpack version and reworked configs for breaking changes * fix: swapped enforce rules by accident, fix this * fix: fix version, as well as convert loaders to rules for future api changes * chore: update webpack to beta.24 * chore(npm): updated webpack to beta.25 * chore(lint): remove rogue double quote * Added augmented module typings for webpack v2 supporting webpack.LoaderOptionsPlugin * chore(lint): linting chores spaces, return lines, semis * chore(npm): updated both package.jsons cause who forgets to do that
The current template produces disjunct list items so the numbering contains only 1's. Let's make this a H3
…ar#2367) E2E test would fail when using a prefix to generate the app
…te for new apps (angular#2455) Fixes angular#2446
Fix angular#2148 Fix angular#2020 Fix angular#2826 Close angular#2646
Pass appConfig.index to the HtmlWebpackPlugin’s filename property. Closes angular#2241 Closes angular#2767
Adding `.c9` to `.gitignore`. `.c9` is from Cloud9 IDE, an editor in the browser. Partnered with Google to [connect Google App Engine apps](https://c9.io/blog/build-apps-for-google-cloud-platform-on-cloud9/). [Purchased by Amazon](https://c9.io/blog/great-news/) a month ago. The best way to code on a Chromebook. Close angular#2782
[Autoprefixer](https://github.com/postcss/autoprefixer) is a tool that uses data from caniuse.com to add vendor prefixes for styles that need them. It saves developers from having to manually prefix things, and is widely used these days. Since it's available as a postcss plugin, it makes sense to inlcude it in the angular-cli build step by default. This implementation uses the default browser targeting settings: last two versions, or whatever's in the user's project's [browserslist](https://github.com/ai/browserslist). Closes angular#1512. Close angular#2852
Fix angular#2812 Feat - add support for unused CSS in components with enabled `ViewEncapsulation`. Close angular#2864
See angular#2410 (comment) for more information. Close angular#2870
We still consider the genDir property in the ngOptions of the tsconfig, to stay compatible with code that works with ngc. Fixes angular#2849. Close angular#2876
We had CommonsChunkPlugin misconfigured to remove the chunkhash in inline.js. Partially address angular#2307 Close angular#2899
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Closed
|
@texel the CI errors are unrelated to your work, it's something we're fixing in another PR. The CLA is something we need though, and can't merge without. |
|
@googlebot I signed it! |
|
@texel the bot doesn't seem to recognize the CLA. Did you use the same email as the one you have in your github profile when you signed it? |
|
@Meligy no, I'm gonna get that fixed ASAP. |
texel
force-pushed
the
fix-fork-checker
branch
from
225a5c9 to
7ce9988
Compare
|
Oops, tried to update my email address in the relevant commits, that didn't go so well. Will close this PR and reopen. |
|
New PR: #3011 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option for awesome-typescript-loader to fork the type checker is
forkChecker, notuseForkChecker. This change forks the type checker, and drastically lowers reload times (from ~4sec to ~1.5sec on a new project on my machine).