Skip to content

fix(@angular/ssr): prevent route matcher error when SSR routing is not used #29421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

alan-agius4
Copy link
Collaborator

Although route matchers are not supported with the SSR Routing API, they still function with the legacy CommonEngine. Therefore, no error should be issued in this case.

Closes #29420

…t used

Although route matchers are not supported with the SSR Routing API, they still function with the legacy `CommonEngine`. Therefore, no error should be issued in this case.

Closes angular#29420
@alan-agius4 alan-agius4 requested a review from dgp1130 January 20, 2025 14:57
@alan-agius4 alan-agius4 requested review from clydin and removed request for dgp1130 January 20, 2025 14:58
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 20, 2025
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 20, 2025
@alan-agius4 alan-agius4 merged commit f3a9233 into angular:main Jan 20, 2025
33 of 34 checks passed
@alan-agius4 alan-agius4 deleted the route-matcher-error branch January 20, 2025 15:17
@alan-agius4
Copy link
Collaborator Author

The changes were merged into the following branches: main, 19.1.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/ssr target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Since 19.1: CommonEngine SSR App crashing in 19.1 when UrlMatcher is used
2 participants