Skip to content

fix(@angular/ssr): properly manage catch-all routes with base href #29414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alan-agius4
Copy link
Collaborator

This fix ensures that catch-all routes (e.g., wildcard routes like **) are handled correctly when a base href is configured in an Angular SSR application.

Closes #29397

@alan-agius4 alan-agius4 requested a review from dgp1130 January 20, 2025 12:43
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jan 20, 2025
@alan-agius4 alan-agius4 force-pushed the handle-catch-all-with-base-href branch from a98ca56 to 227e10a Compare January 20, 2025 12:44
This fix ensures that catch-all routes (e.g., wildcard routes like `**`) are handled correctly when a base href is configured in an Angular SSR application.

Closes angular#29397
@alan-agius4 alan-agius4 force-pushed the handle-catch-all-with-base-href branch from 227e10a to d517f7e Compare January 22, 2025 07:59
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 22, 2025
@alan-agius4 alan-agius4 merged commit 3546c6d into angular:main Jan 22, 2025
27 of 30 checks passed
@alan-agius4 alan-agius4 deleted the handle-catch-all-with-base-href branch January 22, 2025 08:06
@alan-agius4
Copy link
Collaborator Author

The changes were merged into the following branches: main, 19.1.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/ssr target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prerendering doesn't generate index.html for root path of localized website versions
2 participants