Skip to content

fix(@angular/ssr): disable component bootstrapping during route extraction #29101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

alan-agius4
Copy link
Collaborator

This commit disables component bootstrapping during route extraction to prevent invoking the AppComponent and its lifecycle hooks.

Closes #29085

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Dec 10, 2024
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 11, 2024
@alan-agius4 alan-agius4 force-pushed the disable-component-bootstrap branch from 776f0cb to 61ec9c7 Compare December 11, 2024 13:06
@alan-agius4 alan-agius4 force-pushed the disable-component-bootstrap branch from 61ec9c7 to bc8531d Compare December 11, 2024 13:07
…ction

This commit disables component bootstrapping during route extraction to prevent invoking the AppComponent and its lifecycle hooks.

Closes angular#29085
@alan-agius4 alan-agius4 force-pushed the disable-component-bootstrap branch from bc8531d to 6ecd5df Compare December 11, 2024 13:28
@alan-agius4 alan-agius4 removed the request for review from pkozlowski-opensource December 11, 2024 16:25
@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 11, 2024
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Dec 11, 2024
@alan-agius4 alan-agius4 merged commit 10a5b8b into angular:main Dec 11, 2024
31 checks passed
@alan-agius4
Copy link
Collaborator Author

The changes were merged into the following branches: main, 19.0.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/ssr target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Route extraction shouldnt load the whole app in dev server
2 participants