Skip to content

fix(@angular-devkit/build-angular): improve quality of localized source maps #17266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

clydin
Copy link
Member

@clydin clydin commented Mar 21, 2020

Fixes: #17131

@clydin clydin added the target: patch This PR is targeted for the next patch release label Mar 21, 2020
@clydin clydin requested a review from alan-agius4 March 21, 2020 03:35
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Mar 23, 2020
@ngbot
Copy link

ngbot bot commented Mar 23, 2020

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/angular: size" is failing
    failure status "ci/circleci: e2e-cli" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@dgp1130 dgp1130 merged commit 2e84203 into angular:master Mar 24, 2020
@clydin clydin deleted the i18n-sourcemaps branch March 24, 2020 00:30
@dgp1130
Copy link
Collaborator

dgp1130 commented Mar 24, 2020

Also merged to 9.1.x patch branch.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty source map with localization and --watch
4 participants