Skip to content

fix(@schematics/angular): add include to type definitions in tsconfig #16939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2020
Merged

fix(@schematics/angular): add include to type definitions in tsconfig #16939

merged 1 commit into from
Feb 12, 2020

Conversation

alan-agius4
Copy link
Collaborator

Fixes #16923

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Feb 11, 2020
@alan-agius4 alan-agius4 requested a review from clydin February 11, 2020 18:36
@alan-agius4 alan-agius4 marked this pull request as ready for review February 12, 2020 06:07
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Feb 12, 2020
@dgp1130 dgp1130 merged commit bf04333 into angular:master Feb 12, 2020
@dgp1130
Copy link
Collaborator

dgp1130 commented Feb 12, 2020

Also merged to 9.0.x patch branch.

@alan-agius4 alan-agius4 deleted the tsconfig-include-migration branch February 12, 2020 21:04
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clydin clydin clydin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ng update should detect typings files and added it to the appropriate tsconfig file
4 participants
@alan-agius4 @dgp1130 @clydin @googlebot