fix(@ngtools/webpack): NGCC should process secondary entry-points #14934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously secondary entry-points, e.g `@angular/common/http`, were being resolved to the primary entry-point, e.g `@angular/common`. This meant that these entry-points were not being processed as part of a compilation leading to error messages. This change inverts the `tryResolvePackage` logic to attempt to use `require.resolve()` first and only looking in the parent directory of the typings file as a fallback if the main resolve fails. Fixes angular/angular#30972 (comment)
petebacondarwin
added
type: bug/fix
effort1: easy (hours)
P3
alan-agius4
added
target: major
|
Awesome @petebacondarwin. I was upgrading my library to use Angular CLI and stumbled upon the same issue with IVY. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously secondary entry-points, e.g
@angular/common/http, were being resolved tothe primary entry-point, e.g
@angular/common.This meant that these entry-points were not being
processed as part of a compilation leading to error messages.
This change inverts the
tryResolvePackagelogicto attempt to use
require.resolve()first and onlylooking in the parent directory of the typings file
as a fallback if the main resolve fails.
Fixes angular/angular#30972 (comment)