DL fixes for safari and false negatives for ES6 module support (PATCH) #14730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and iOS Safari 10.3 The nomodule polyfill needs to be loaded prior to any script and be outside of webpack compilation because otherwise webpack will cause the script to be wrapped in `window["webpackJsonp"]` which causes it to fail. This polyfill will only be injected when the either Safari 10.1 or iOS Safari 10.3 support is required, which is based on the browsers defined in browserslist file. Fixes #14680
alan-agius4
added
the
target: major
alan-agius4
added
target: rc
clydin
approved these changes
Jun 11, 2019
packages/angular_devkit/build_angular/src/utils/build-browser-features.ts
Outdated
Show resolved
Hide resolved
…s6 modules are being marked as not supported caniuse-api only returns true for a feature when it's fully supported. This might causes redundant ES5 builds if users opt to support only browsers which do support ES6 modules but either require polyfills such as Safari 10.1 or when both bundles will be downloaded such as Edge 18 See: https://github.com/Nyalab/caniuse-api/blob/1b74c10257e36877709da4f6630513db10203a78/src/index.js#L49 and Nyalab/caniuse-api#82 Fixes #14580
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch version of #14716 as it doesn't apply cleanly