fix(@schematics/angular): skip E2E projects when migrating browserslist

clydin · alexeagle · commit c80a92ac675e · 2019-04-22T13:29:05.000-07:00
diff --git a/packages/schematics/angular/migrations/update-8/differential-loading.ts b/packages/schematics/angular/migrations/update-8/differential-loading.ts
@@ -95,14 +95,17 @@ function updateBrowserlist(): Rule {
     }
 
     // For all projects
-    for (const projectName of Object.keys(angularJson.projects)) {
-      const project = angularJson.projects[projectName];
+    for (const [name, project] of Object.entries(angularJson.projects)) {
       if (!isJsonObject(project)) {
         continue;
       }
       if (typeof project.root != 'string' || project.projectType !== 'application') {
         continue;
       }
+      if (name.endsWith('-e2e')) {
+        // Skip existing separate E2E projects
+        continue;
+      }
 
       const browserslistPath = join(normalize(project.root), '/browserslist');
       const source = tree.read(browserslistPath);

Original file line number	Diff line number	Diff line change
`@@ -95,14 +95,17 @@ function updateBrowserlist(): Rule {`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`// For all projects`
`98`		`- for (const projectName of Object.keys(angularJson.projects)) {`
`99`		`- const project = angularJson.projects[projectName];`
	`98`	`+ for (const [name, project] of Object.entries(angularJson.projects)) {`
`100`	`99`	`if (!isJsonObject(project)) {`
`101`	`100`	`continue;`
`102`	`101`	`}`
`103`	`102`	`if (typeof project.root != 'string' \|\| project.projectType !== 'application') {`
`104`	`103`	`continue;`
`105`	`104`	`}`
	`105`	`+ if (name.endsWith('-e2e')) {`
	`106`	`+ // Skip existing separate E2E projects`
	`107`	`+ continue;`
	`108`	`+ }`
`106`	`109`
`107`	`110`	`const browserslistPath = join(normalize(project.root), '/browserslist');`
`108`	`111`	`const source = tree.read(browserslistPath);`