fix(@angular/cli): handle format path in invoked schematics

With this change we change the how we handle `"format": "path"` schematic property option. Previously, in version 14 this format was only being applied on parent schematics that were registered as commands. With this change we apply the formatter on all options, even those who are called programmatically using APIs like `externalSchematic`.

Author: alan-agius4

packages/angular/cli/src/command-builder/schematics-command-module.ts

@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import { normalize as devkitNormalize, schema, tags } from '@angular-devkit/core';
+import { normalize as devkitNormalize, isJsonObject, schema, tags } from '@angular-devkit/core';
 import { Collection, UnsuccessfulWorkflowExecution, formats } from '@angular-devkit/schematics';
 import {
   FileSystemCollectionDescription,
@@ -135,12 +135,14 @@ export abstract class SchematicsCommandModule
     workflow.registry.addPostTransform(schema.transforms.addUndefinedDefaults);
     workflow.registry.useXDeprecatedProvider((msg) => logger.warn(msg));
     workflow.registry.addSmartDefaultProvider('projectName', () => this.getProjectName());
-    workflow.registry.addSmartDefaultProvider(
-      'workingDirectory',
-      () => devkitNormalize(relative(this.context.root, process.cwd())) || undefined,
+
+    const workingDir = devkitNormalize(relative(this.context.root, process.cwd()));
+    workflow.registry.addSmartDefaultProvider('workingDirectory', () =>
+      workingDir === '' ? undefined : workingDir,
     );
 
     let shouldReportAnalytics = true;
+
     workflow.engineHost.registerOptionsTransform(async (schematic, options) => {
       if (shouldReportAnalytics) {
         shouldReportAnalytics = false;
@@ -154,6 +156,35 @@ export abstract class SchematicsCommandModule
         ]);
       }
 
+      // TODO: The below should be removed in version 15 when we change 1P schematics to use the `workingDirectory smart default`.
+      // Handle `"format": "path"` options.
+      const schema = schematic?.schemaJson;
+      if (!options || !schema || !isJsonObject(schema)) {
+        return options;
+      }
+
+      if (!('path' in options && (options as Record<string, unknown>)['path'] === undefined)) {
+        return options;
+      }
+
+      const properties = schema?.['properties'];
+      if (!properties || !isJsonObject(properties)) {
+        return options;
+      }
+
+      const property = properties['path'];
+      if (!property || !isJsonObject(property)) {
+        return options;
+      }
+
+      if (property['format'] === 'path' && !property['$default']) {
+        (options as Record<string, unknown>)['path'] = workingDir || undefined;
+        this.context.logger.warn(
+          `The 'path' option in '${schematic?.schema}' is using deprecated behaviour.` +
+            `'workingDirectory' smart default provider should be used instead.`,
+        );
+      }
+
       return options;
     });