Skip to content

Commit 4323e5b

Browse files
committed
ci: ensure passing build before rest of CI jobs
(cherry picked from commit 673388a)
1 parent 6ff3144 commit 4323e5b

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ jobs:
5353
run: yarn ng-dev release build
5454

5555
test:
56+
needs: build
5657
runs-on: ubuntu-latest
5758
steps:
5859
- name: Initialize environment
@@ -69,6 +70,7 @@ jobs:
6970
ASPECT_RULES_JS_FROZEN_PNPM_LOCK: '1'
7071

7172
e2e:
73+
needs: build
7274
strategy:
7375
fail-fast: false
7476
matrix:
@@ -101,6 +103,7 @@ jobs:
101103
run: yarn bazel test --define=E2E_SHARD_TOTAL=6 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.${{ matrix.subset }}_node${{ matrix.node }}
102104

103105
e2e-package-managers:
106+
needs: build
104107
strategy:
105108
fail-fast: false
106109
matrix:
@@ -122,6 +125,7 @@ jobs:
122125
run: yarn bazel test --define=E2E_SHARD_TOTAL=3 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.${{ matrix.subset }}_node${{ matrix.node }}
123126

124127
e2e-snapshots:
128+
needs: build
125129
strategy:
126130
fail-fast: false
127131
matrix:
@@ -143,6 +147,7 @@ jobs:
143147
run: yarn bazel test --define=E2E_SHARD_TOTAL=6 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.snapshots.${{ matrix.subset }}_node${{ matrix.node }}
144148

145149
browsers:
150+
needs: build
146151
runs-on: ubuntu-latest
147152
name: Browser Compatibility Tests
148153
env:
@@ -177,6 +182,7 @@ jobs:
177182
path: ${{ env.SAUCE_CONNECT_DIR_IN_HOST }}/sauce-connect.log
178183

179184
publish-snapshots:
185+
needs: build
180186
runs-on: ubuntu-latest
181187
env:
182188
CIRCLE_BRANCH: ${{ github.ref_name }}

0 commit comments

Comments
 (0)