fix(@angular-devkit/build-angular): avoid repeat error clear in vite development server

clydin · clydin · commit 0c982b993b69 · 2023-10-18T15:05:08.000-04:00
In the Vite-based development server, an error overlay is requested if a build encounters an error. This error is then cleared when the error is corrected. However, the flag indicating that the error was cleared was not previously reset. This resulted in additional empty update commands being sent to the Vite client. While this has no visual effect, it is unneeded additional processing. (cherry picked from commit 660bb0a)
diff --git a/packages/angular_devkit/build_angular/src/builders/dev-server/vite-server.ts b/packages/angular_devkit/build_angular/src/builders/dev-server/vite-server.ts
@@ -151,6 +151,7 @@ export async function* serveWithVite(
       }
       continue;
     } else if (hadError && server) {
+      hadError = false;
       // Send an empty update to clear the error overlay
       server.ws.send({
         'type': 'update',

Original file line number	Diff line number	Diff line change
`@@ -151,6 +151,7 @@ export async function* serveWithVite(`
`151`	`151`	`}`
`152`	`152`	`continue;`
`153`	`153`	`} else if (hadError && server) {`
	`154`	`+ hadError = false;`
`154`	`155`	`// Send an empty update to clear the error overlay`
`155`	`156`	`server.ws.send({`
`156`	`157`	`'type': 'update',`