This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
Track groups by their name - Fix issue #1721 #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you confirmed this improves performance issues mentioned in #1721? |
user378230
added
performance
needs: review
needs: info
and removed
needs: review
labels
|
Without it, any scope created inside a ui-select-choice gets destroyed whenever the array changes (I checked it by listening for the $destroy event). If you add "track by $group.name", this no longer happens, unless the item is actually removed from the array. |
|
Ok I'll trust you! 😃 The commit message needs to match our format as per CONTRIBUTING.mdif you can do this great else will have to wait till I can spare a moment. |
Use "track by" to track groups of choices by their name instead of the $$hastKey. This way, existing items don't have to be re-rendered when the array of items changes. Closes angular-ui#1721
|
Updated the commit message. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using "track by", existing items don't have to be re-rendered when the array changes.