-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Angular 1.5.x with ngAnimate still do multiple $digest #1502
Comments
You should post a reproduction - this is not a useful issue with the information mentioned. |
ok here is plunkr: Test process
Results
This killing slower computers. Everything work corectly when you turn off ngAnimate or just ctrl.$animate return false state. tested in chrome, bc ff is dead after 5-10 iterations |
+1 also seeing really poor jQuery related performance during mouse interaction. don't have time to refactor this code.. switching to select2 4.0.2 and creating my own angular wrapper |
I have replicated the issue in our own web app and in the plunkr linked by @KrakenTyP-co |
I have also replicated this in the supplied plunkr and in my own web app. My ui-select has over 800 items and it is virtually unusable with $animate enabled. |
Also adversely affected by this. My workaround was to use the Although, as I test further, I see I was inadvertently disabling all animation, not just the animation for that element... |
We've also been having some performance issues with In addition, there is a way to make the change on a per-instance basis and without forking the repository or keeping a locally modified copy of the library. We created a directive that requires
and use as follows:
|
Hi,
after updating angular 1.5.1 with ngAnimate is still there bug with multiple triggering $digest.
Problem - Multiple opening same uiSelect triggering duplicity $digest`s.
This bug was ignored with reference to bug on ngAnimate 1.5.0.
Im updated uiSelect 0.16.0 but still its not working propertly.
For now i changed code like this:
ctrl.$animate = (function () {
try {
// return $injector.get('$animate');
return null;
} catch (err) {
// $animate does not exist
return null;
}
})();
The text was updated successfully, but these errors were encountered: