Merge pull request #1402 from dontgitit/master

fix #1400
angular-ui · Jan 27, 2016 · dc7f0d2 · dc7f0d2 · pehrlich · Jan 28, 2016
2 parents 86e4a82 + e3d6b71
commit dc7f0d2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/common.js b/src/common.js
@@ -135,7 +135,7 @@ var uis = angular.module('ui.select', [])
  */
 .filter('highlight', function() {
   function escapeRegexp(queryToEscape) {
-    return queryToEscape.replace(/([.?*+^$[\]\\(){}|-])/g, '\\$1');
+    return ('' + queryToEscape).replace(/([.?*+^$[\]\\(){}|-])/g, '\\$1');
   }
 
   return function(matchItem, query) {

diff --git a/test/select.spec.js b/test/select.spec.js
@@ -2328,6 +2328,13 @@ describe('ui-select tests', function() {
 
       expect(highlight(item, query)).toBe('20<span class="ui-select-highlight">15</span>');
     });
+
+    it('properly works with numeric queries', function() {
+      var query = 15;
+      var item = 2015;
+
+      expect(highlight(item, query)).toBe('20<span class="ui-select-highlight">15</span>');
+    });
   });
 
 });