Ensuring stable sort of route rules used for matching URLs.

[cdriscol]

This is the fix for #2501.

[cdriscol]

These rule definitions may seem abundant - but it was the only way I could consistently reproduce the stable sorting issue in Chrome.

[nateabele]

Wow, nice! Thanks for doing the research on this. We were just gonna roll back #1585, but this seems like a better solution for sure. /cc @christopherthielen

[cdriscol]

Ensures a stable sort in Chrome browsers

[christopherthielen]

I really do like the idea of ordering the rules by specificity by default. We should definitely do that for 1.0.

My main concern with #1585 is that it's a legitimate breaking change from 0.2.15. For years we've told people that url rules are checked in the order that they were registered, and that they should re-order the registration of those rules if they need to change match priority.

Because sorting rules was a BC for 0.2.x, however, I think we should do one of three things for 0.2.18:

• roll back fix($urlRouter): resolve clashing of routes #1585 completely
• allow users to select which strategy
  • insertion order
  • specificity sort order, including Ensuring stable sort of route rules used for matching URLs. #2502
• allow users to provide their own sorting algorithm

[nateabele]

Yeah, fair enough. @cdriscol Update the PR to point to feature-1.0 and we'll merge it. @christopherthielen Yeah, fair enough. We'll just roll back #1585 for .18, merge this for 1.0, and implement sort strategies when we get time.

[chino23]

could this fix be released with a quick minor update soon?

[cdriscol]

@nateabele - I will get this into the feature-1.0 branch when I get some time in the next couple days.

will be good to get the sort rolled back in 0.2.18

[sebastiannm]

It would be good to release a new version for this soon. I found that it breaks a lot of stuff

[nateabele]

@sebastiannm Yup, that's why it's going into 1.0 only, and the previous version is being rolled back.

[JetFault]

@nateabele When do ya think the 0.2.18 release will come out? Just noticed this broke my app so had to revert to .15

[nateabele]

@JetFault Hard to say. We have this and one or two other BC breaks to patch up.