Skip to content

Transcluding the of ui-view directive, ui-view spec, example of the initial view in the sample app #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 22, 2013

Conversation

adambabik
Copy link
Contributor

This pull request refers to the issue number #142.

The ui-view spec contains just basic tests, it definitely needs to be expanded. However, it's a good start I guess.

The example of the initial view in the sample app may be unclear for some people. I've implemented it just to see how it works in the real app.

ksperling added a commit that referenced this pull request Jun 22, 2013
Transcluding the of ui-view directive, ui-view spec, example of the initial view in the sample app
@ksperling ksperling merged commit 2da2710 into angular-ui:master Jun 22, 2013
@adambabik adambabik deleted the issue-142 branch June 22, 2013 21:58
@nateabele
Copy link
Contributor

@riccardo-forina Awesome, thanks for the reproduce code. This is probably deserving of its own issue, so go ahead and open a new one. If I had to guess, I'd say that this has to do with having a ui-view as the root of a template that gets loaded into a ui-view, consequently having them nested one directly within the other.

In any case, I'll take a look at this as soon as I'm done with some other stuff I'm in the middle of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants