fix($urlRouter): resolve clashing of routes#1585
Merged
nateabele merged 1 commit intoangular-ui:masterfrom Sep 23, 2015
just-boris:master
Merged
fix($urlRouter): resolve clashing of routes#1585nateabele merged 1 commit intoangular-ui:masterfrom just-boris:master
nateabele merged 1 commit intoangular-ui:masterfrom
just-boris:master
Conversation
Contributor
|
What are your thoughts on this @nateabele ? This sounds sane, but there is still some ambiguity with states with the same level of specificity. |
Contributor
|
@wesleycho I don't actually remember what I was gonna do here, but this solution seems fine for now. |
nateabele
added a commit
that referenced
this pull request
Sep 23, 2015
fix($urlRouter): resolve clashing of routes
Contributor
|
@wesleycho Btw, any PRs that get merged to master from here out, be sure to flag them on the 1.0-preview milestone so we can review. /cc @christopherthielen |
This was referenced Jan 24, 2016
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes url can be matched by several different rules. Now it will be handled by the first rule in order of appearance. So it causes some issues. It would be better to match states from more specified to common.
Angular-route already has same issue angular/angular.js#8266
So, I propose include this fixes here, because is ui-router more powerful and flexible library.